Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix torchvision installation in tpu ci test setup script #6704

Merged
merged 13 commits into from
Mar 12, 2024

Conversation

lsy323
Copy link
Collaborator

@lsy323 lsy323 commented Mar 8, 2024

Currently in TPU CI, we are installing torch nightly whl before running tests, however, in TPU CI, torch_xla is built against PyTorch HEAD. This would cause some compatibility issues. (e.g. Symbol mismatching in .so)

  • torchaudio is not needed for CI, remove torchaudio installation in the setup script as well.

  • Instead of installing nightly torchvision, use the torchvision version pinned in PyTorch src folder.

@lsy323
Copy link
Collaborator Author

lsy323 commented Mar 11, 2024

Cannot find a way to read the pytorch/.github/ci_commit_pins in test/tpu/xla_test_job.yaml.

When doing pip install "git+https://github.com/pytorch/vision.git@$TORCHVISION_COMMIT", $TORCHVISION_COMMIT will be an empty str.

To rule out the fact that we cannot change env var in the .yaml config files, I put the pip command in a shell script but looks like the path src/pytorch/.github/ci_commit_pins is not valid.

Copy link
Collaborator

@will-cromar will-cromar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also mirror the fix to the GHA CI if it works? https://github.com/pytorch/xla/blob/master/.github/workflows/tpu_ci.yml

The commit pin will be more readily available.

@lsy323 lsy323 force-pushed the lsiyuan/tpu-ci-remove-torch-whl-install branch from 475deda to c5b1a6c Compare March 12, 2024 00:59
@lsy323
Copy link
Collaborator Author

lsy323 commented Mar 12, 2024

Can you also mirror the fix to the GHA CI if it works? https://github.com/pytorch/xla/blob/master/.github/workflows/tpu_ci.yml

The commit pin will be more readily available.

I had a few attempts in the previous commits fixing the GHA TPU CI, but failed to do so, let's land the fix for installing torchvision properly for the old TPU CI.

@lsy323 lsy323 self-assigned this Mar 12, 2024
@lsy323 lsy323 marked this pull request as ready for review March 12, 2024 18:31
@lsy323 lsy323 requested a review from will-cromar March 12, 2024 21:26
@lsy323 lsy323 merged commit d5a079e into master Mar 12, 2024
19 checks passed
@lsy323 lsy323 deleted the lsiyuan/tpu-ci-remove-torch-whl-install branch March 12, 2024 23:42
@lsy323
Copy link
Collaborator Author

lsy323 commented Mar 13, 2024

@lsy323 lsy323 added CI CI related change backport_2.3 labels Mar 13, 2024
lsy323 added a commit that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport_2.3 CI CI related change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants