Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR#6326 to r2.2 #6330

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Backport PR#6326 to r2.2 #6330

merged 1 commit into from
Jan 20, 2024

Conversation

yeounoh
Copy link
Contributor

@yeounoh yeounoh commented Jan 19, 2024

Backport PR#6326 to fix a regression bug.

@yeounoh yeounoh requested a review from zpcore January 19, 2024 02:15
@yeounoh yeounoh self-assigned this Jan 19, 2024
Copy link
Collaborator

@zpcore zpcore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@ManfeiBai ManfeiBai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zpcore
Copy link
Collaborator

zpcore commented Jan 19, 2024

Oh, wait, there is a CPU test failure.

@yeounoh yeounoh force-pushed the backport_all_reduce_fix branch from 178e311 to 1fad0a8 Compare January 20, 2024 00:26
@yeounoh
Copy link
Contributor Author

yeounoh commented Jan 20, 2024

Rebased after torch_pin update.

@ManfeiBai ManfeiBai merged commit c0e522c into r2.2 Jan 20, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants