Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Set all_reduce_token to None when exiting" #6321

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Revert "Set all_reduce_token to None when exiting" #6321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6eecf41
Revert "Set all_reduce_token to None when exiting"
vanbasten23 Jan 18, 2024
4e4d9c4
try reverse another change after this commit.
vanbasten23 Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/run_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,6 @@ function run_mp_op_tests {
run_test "$CDIR/test_mp_save.py"
run_test "$CDIR/test_mp_mesh_reduce.py"
run_test "$CDIR/test_mp_sync_batch_norm.py"
run_test "$CDIR/test_mp_early_exit.py"
run_pt_xla_debug "$CDIR/debug_tool/test_mp_pt_xla_debug.py"
run_xla_backend_mp "$CDIR/test_torch_distributed_all_gather_xla_backend.py"
run_xla_backend_mp "$CDIR/test_torch_distributed_all_reduce_xla_backend.py"
Expand Down
26 changes: 0 additions & 26 deletions test/test_mp_early_exit.py
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions test/test_zero1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
class XlaZeRO1Test(TestCase):

@unittest.skipIf(xr.device_type() == 'TPU', "Crash on TPU")
@unittest.skipIf(xr.device_type() == 'CUDA', "Crash on CUDA")
def test_zero1(self):
device = xm.xla_device()

Expand Down
2 changes: 0 additions & 2 deletions torch_xla/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,6 @@ def _setup_tpu_vm_library_path() -> bool:


def _prepare_to_exit():
device = _XLAC._xla_get_default_device()
_XLAC._set_all_reduce_token(device, None)
_XLAC._prepare_to_exit()
if int(os.environ.get('PT_XLA_DEBUG', '0')):
_summarize_fn_tracker()
Expand Down