Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] use self.assertEquals instead of str equality in test_zero1.py #5358

Closed
wants to merge 1 commit into from

Conversation

janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Jul 27, 2023

Make the error messaging more useful. Recently came across this error which the vanilla assert was not helpful.
image

Where the error occurred: https://hud.pytorch.org/pr/106082

Stack from ghstack (oldest at bottom):

janeyx99 added a commit that referenced this pull request Jul 27, 2023
ghstack-source-id: a26e45be13c9d980b913fd91ad96c84ea4b24119
Pull Request resolved: #5358
@janeyx99 janeyx99 requested a review from JackCaoG July 27, 2023 15:24
@janeyx99
Copy link
Contributor Author

Closing in favor of #5364

@janeyx99 janeyx99 closed this Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants