-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move CI to GitHub Actions #5045
Conversation
1700c4b
to
3a941d1
Compare
@malfet Test is green now, is this one ready to be reviewed? |
@JackCaoG it's missing codecov and doc push steps, working on adding them now, and than it'll be ready |
Add more steps Add concurrency and workflow dispatch Auth to GCR Use `quiet` instead of yes Add upload and test (on CPU) steps
08ba2a4
to
e6b3b85
Compare
@JackCaoG I think it is ready now with a small caveat of adding a doc push step, which if you don't mind I'll do after current CI run finishes (want to make sure that codecov upload logic works as expected) |
Thanks @malfet this is super exciting. I will take a look tmr after test is green. |
Hmm, interestingly job OOMs, (even though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
was perusing this file for an example to work off of and noticed this typo: |
@Subbarker thanks, fixing in #5172 |
This PR migrates CircleCI workflow to GHA and makes a few minor changes:
_build.yml
,_test.yml
and_docs.yml
Test plan:
TODO:
config.yml
and no-longer used steps from.circleci/common.sh