Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CI to GitHub Actions #5045

Merged
merged 17 commits into from
May 24, 2023
Merged

Move CI to GitHub Actions #5045

merged 17 commits into from
May 24, 2023

Conversation

malfet
Copy link
Collaborator

@malfet malfet commented May 22, 2023

This PR migrates CircleCI workflow to GHA and makes a few minor changes:

  • Upload intermediary docker containers from GCR to ECR (as they are faster to download and do not incur egress costs to the infra)
  • For the same reason, workflows no longer require AWS credentials, as runners provision to have write access to the bucket/ECR
  • Skip the logic of rebasing PRs against latest trunk, as GH is doing it automatically
  • Build/publish docs on trunk in parallel to CPU tests build
  • Rely on GitHub reusable workflows and split workflow into _build.yml, _test.yml and _docs.yml

Test plan:

  • Enable codecov collection on PRs and test that it works (see this log)
  • Test docs build (see this log)

TODO:

  • Test/migrate doc-push step
  • Test/migrate code coverage collection step
  • Delete config.yml and no-longer used steps from .circleci/common.sh

@malfet malfet force-pushed the malfet/circleci-to-gha branch 6 times, most recently from 1700c4b to 3a941d1 Compare May 23, 2023 06:05
@JackCaoG
Copy link
Collaborator

@malfet Test is green now, is this one ready to be reviewed?

@malfet
Copy link
Collaborator Author

malfet commented May 23, 2023

@JackCaoG it's missing codecov and doc push steps, working on adding them now, and than it'll be ready

malfet added 8 commits May 23, 2023 15:43
Add more steps
Add concurrency and workflow dispatch
Auth to GCR
Use `quiet` instead of yes
Add upload and test (on CPU) steps
@malfet malfet force-pushed the malfet/circleci-to-gha branch from 08ba2a4 to e6b3b85 Compare May 23, 2023 23:56
@malfet malfet marked this pull request as ready for review May 24, 2023 00:58
@malfet malfet requested a review from JackCaoG May 24, 2023 00:58
@JackCaoG JackCaoG requested review from will-cromar and yeounoh May 24, 2023 01:00
@malfet
Copy link
Collaborator Author

malfet commented May 24, 2023

@JackCaoG I think it is ready now with a small caveat of adding a doc push step, which if you don't mind I'll do after current CI run finishes (want to make sure that codecov upload logic works as expected)

@JackCaoG
Copy link
Collaborator

Thanks @malfet this is super exciting. I will take a look tmr after test is green.

@malfet
Copy link
Collaborator Author

malfet commented May 24, 2023

Hmm, interestingly job OOMs, (even though linux.4xlarge should have 32Gb of RAM), will try to upgrade to linux.12xlarge, which has 96Gb of RAM

Copy link
Collaborator

@JackCaoG JackCaoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@malfet malfet merged commit 2b0abba into master May 24, 2023
@malfet malfet deleted the malfet/circleci-to-gha branch May 24, 2023 20:18
@Subbarker
Copy link

was perusing this file for an example to work off of and noticed this typo: metadtaa.json

@malfet
Copy link
Collaborator Author

malfet commented Jun 13, 2023

@Subbarker thanks, fixing in #5172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants