-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add short_metrics #4148
Merged
Merged
Add short_metrics #4148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee594e8
to
c70be32
Compare
will-cromar
reviewed
Nov 2, 2022
will-cromar
reviewed
Nov 2, 2022
will-cromar
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
alanwaketan
added a commit
to pytorch/pytorch
that referenced
this pull request
Nov 17, 2022
Summary: This pull request upstreams pytorch/xla#4148. Test Plan: xla CI.
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Nov 18, 2022
Summary: This pull request upstreams pytorch/xla#4148. Test Plan: xla CI. Pull Request resolved: #89186 Approved by: https://github.com/JackCaoG
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
Summary: This pull request upstreams pytorch/xla#4148. Test Plan: xla CI. Pull Request resolved: pytorch#89186 Approved by: https://github.com/JackCaoG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr added an api
short_metrics_report
which by defualt will emit a very short list of relevant metrics. User can also customize which metrics they want to see. IMO full metrics is way too detail in most time.We will always print out the
aten::
counters since they indicate fallback and are important to users.example output: