Node hash new #3514
Merged
Node hash new #3514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wconstab
approved these changes
Apr 20, 2022
antoniojkim
reviewed
Apr 20, 2022
antoniojkim
approved these changes
Apr 20, 2022
|
@wconstab pin to #75324 will checkout that pytorch branch when building in pt/xla CI. We will run both CPU and GPU test so it should be enough to cover :D. |
Merged
JackCaoG
added a commit
that referenced
this pull request
Apr 21, 2022
JackCaoG
added a commit
that referenced
this pull request
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix the build error in pytorch/pytorch#75324. Pytorch/xla needs to implement two hash function and maintain the hash object.
From PyTorch/XLA's perspective,
hashandshape_hashis the same thing.