Add v4 config to xla_dist #3440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miladm
reviewed
Mar 28, 2022
| @@ -316,6 +316,17 @@ def _tpuvm_env_vars_cmd(self, worker_idx): | |||
| 'v3-512': '8,8,1', | |||
| 'v3-1024': '8,16,1', | |||
| 'v3-2048': '16,16,1', | |||
| # v4 | |||
There was a problem hiding this comment.
I'd expect these configs to continue growing.
Instead of hard coding these confits, I suggest we moving them to a xla_dist_configs.yaml file.
Wdyt?
There was a problem hiding this comment.
nit: suggesting to include a comment defining dimensions:
number of host machines, number of chips per host machine, number of cores per chip
There was a problem hiding this comment.
I expect this file to be heavily modified after pjrt migration. xla_dist is xrt focus. I think we can clean up the code later.
| @@ -327,6 +338,13 @@ def _tpuvm_env_vars_cmd(self, worker_idx): | |||
|
|
|||
| def _env_vars_cmd(self, worker_idx): | |||
| client_worker = self._cluster.get_client_workers()[worker_idx] | |||
| accelerator_gen = self._cluster.get_service_workers( | |||
| )[0]._machine_type.split('-')[0] | |||
| accelerator_gen_to_tpu_num_devices = { | |||
There was a problem hiding this comment.
I don't think it is worth to put every config into yaml, especially if it only 3 lines long. TPU_NUM_DEVICES will most likely go away after pjrt migration too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently xla_dist does not support v4 since mesh config is missing.