Make v2 transforms authoring public #8787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8787
Note: Links to docs will display an error until the docs builds have been completed. ❌ 24 New FailuresAs of commit 70b47e7 with merge base 48f01de ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hey @NicolasHug! You merged this PR, but no labels were added. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
Reviewed By: vmoens Differential Revision: D68096271 fbshipit-source-id: 4e3098e101d2ac402c5dbf9d4ea38dd1d1d731c1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8721
This PR enables users to implement their own v2 transforms without using private methods. It was so far possible to implement v2 transforms, but private methods were necessary in order to fully support arbitrary inputs.
Concretely, we're now publicly exposing
_transform(),_get_params()(asmake_params()), and_check_inputs().Note that existing users transforms that use these existing (private!) methods may break.
cc @vfdev-5