Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra to install gdown #8430

Merged
merged 3 commits into from
May 20, 2024
Merged

Add extra to install gdown #8430

merged 3 commits into from
May 20, 2024

Conversation

adamjstewart
Copy link
Contributor

Torchvision has an optional dependency on gdown, but this is not currently documented in pyproject.toml or setup.py. This PR adds a new "gdown" extra so that users can install torchvision and its optional dependencies at the same time.

Alternatively, we could create a single unified extra for all optional dataset dependencies like we do in TorchGeo.

Copy link

pytorch-bot bot commented May 19, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8430

Note: Links to docs will display an error until the docs builds have been completed.

❌ 17 New Failures, 19 Unrelated Failures

As of commit 188a8e2 with merge base 8b6c5e7 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @adamjstewart !

@NicolasHug NicolasHug merged commit 51429c2 into pytorch:main May 20, 2024
5 of 15 checks passed
@adamjstewart adamjstewart deleted the deps/gdown branch May 20, 2024 11:46
facebook-github-bot pushed a commit that referenced this pull request May 20, 2024
Summary: Co-authored-by: Nicolas Hug <nh.nicolas.hug@gmail.com>

Reviewed By: vmoens

Differential Revision: D57565244

fbshipit-source-id: 8533ea03bff3651981707dbce4fb6f264bb038f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants