-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra to install gdown #8430
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8430
Note: Links to docs will display an error until the docs builds have been completed. ❌ 17 New Failures, 19 Unrelated FailuresAs of commit 188a8e2 with merge base 8b6c5e7 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @adamjstewart !
Summary: Co-authored-by: Nicolas Hug <nh.nicolas.hug@gmail.com> Reviewed By: vmoens Differential Revision: D57565244 fbshipit-source-id: 8533ea03bff3651981707dbce4fb6f264bb038f2
Torchvision has an optional dependency on gdown, but this is not currently documented in pyproject.toml or setup.py. This PR adds a new "gdown" extra so that users can install torchvision and its optional dependencies at the same time.
Alternatively, we could create a single unified extra for all optional dataset dependencies like we do in TorchGeo.