Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly ignore all video decoding tests #8161

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Explicitly ignore all video decoding tests #8161

merged 4 commits into from
Dec 12, 2023

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Dec 11, 2023 •
edited by pytorch-bot bot
Loading

This includes read_video, VideoReader, and the GPU decoder.

cc @pmeier

@NicolasHug NicolasHug requested a review from pmeier December 11, 2023 15:46
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Dec 11, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8161

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ad55eb8 with merge base 7e9e784 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@NicolasHug NicolasHug changed the title Explicitly ignore all video tests Explicitly ignore all video decoding tests Dec 11, 2023
@NicolasHug NicolasHug mentioned this pull request Dec 11, 2023
Open
pmeier
pmeier approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the video tests scattered across multiple files? If no, it might be safer to just ignore one (or maybe two) files?

@NicolasHug
Copy link
Member Author

The files are test/test_videoapi.py test/test_video_gpu_decoder.py test/test_video_reader.py. I can ignore them individually if you prefer. Just FYI, I also removed the installation of pyav in ad8d410

@pmeier
Copy link
Collaborator

pmeier commented Dec 12, 2023

I'm ok with the glob if we are sure that we are catching everything.

@pmeier
Copy link
Collaborator

pmeier commented Dec 12, 2023

Removal of av has an effect on the doc build: https://github.com/pytorch/vision/actions/runs/7178663743/job/19547292161?pr=8161#step:11:1310

Warning, treated as error:

../../gallery/others/plot_optical_flow.py unexpectedly failed to execute correctly:

    Traceback (most recent call last):
      File "/pytorch/vision/gallery/others/plot_optical_flow.py", line 79, in <module>
        frames, _, _ = read_video(str(video_path), output_format="TCHW")
      File "/pytorch/vision/torchvision/io/video.py", line 276, in read_video
        _check_av_available()
      File "/pytorch/vision/torchvision/io/video.py", line 41, in _check_av_available
        raise av
    ImportError: PyAV is not installed, and is necessary for the video operations in torchvision.
    See https://github.com/mikeboers/PyAV#installation for instructions on how to
    install PyAV on your system.


make: *** [html] Error 2
Error: Process completed with exit code 1.

@NicolasHug NicolasHug merged commit 44a9bea into pytorch:main Dec 12, 2023
64 checks passed
@github-actions GitHub Actions
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@NicolasHug NicolasHug added module: tests other if you have no clue or if you will manually handle the PR in the release notes labels Dec 12, 2023
facebook-github-bot pushed a commit that referenced this pull request Jan 16, 2024
@NicolasHug @facebook-github-bot
[fbsync] Explicitly ignore all video decoding tests (#8161)
48d1de8 
Reviewed By: vmoens

Differential Revision: D52538994

fbshipit-source-id: 4df5cca2e05d47c66166b68ed44b3d9ab23b7979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeier pmeier pmeier approved these changes

Assignees
No one assigned
Labels
cla signed module: tests other if you have no clue or if you will manually handle the PR in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasHug @pmeier @facebook-github-bot