Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix atol in resize_image kernel test #8133

Merged
merged 2 commits into from
Nov 23, 2023
Merged

fix atol in resize_image kernel test #8133

merged 2 commits into from
Nov 23, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Nov 23, 2023 •
edited by pytorch-bot bot
Loading

Since assert bool(transforms.InterpolationMode.BICUBIC) without this PR we are testing all interpolation modes against atol=30 although we want atol=1 for all modes besides bicubic.

cc @vfdev-5

@pmeier pmeier requested a review from NicolasHug November 23, 2023 15:36
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 23, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8133

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (33 Unrelated Failures)

As of commit 0e4ae2b with merge base ec7f80b (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vfdev-5
vfdev-5 approved these changes Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@pmeier pmeier merged commit 1fda0e8 into pytorch:main Nov 23, 2023
@pmeier pmeier deleted the resize-image-kernel-atol branch November 23, 2023 18:59
facebook-github-bot pushed a commit that referenced this pull request Jan 16, 2024
@NicolasHug @facebook-github-bot
[fbsync] fix atol in resize_image kernel test (#8133)
fe72eb7 
Reviewed By: vmoens

Differential Revision: D52539020

fbshipit-source-id: eb831a95f2ccc86521b5b5af8fa5ad1c6e484ea2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

@NicolasHug NicolasHug Awaiting requested review from NicolasHug

Assignees
No one assigned
Labels
bug cla signed module: tests module: transforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmeier @vfdev-5 @facebook-github-bot