port tests for type conversion transforms #8003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8003
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 9abf734 with merge base ee28bb3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
NicolasHug
approved these changes
Sep 29, 2023
| @@ -5046,3 +5046,67 @@ def test_transform_error_cuda(self): | |||
| ValueError, match="Input tensor should be on the same device as transformation matrix and mean vector" | |||
| ): | |||
| transform(input) | |||
|
|
|||
|
|
|||
| def make_image_numpy(*args, **kwargs): | |||
There was a problem hiding this comment.
make_image_pil is only ever used in this file (test/test_transforms_v2_consistency.py), yet it lives in common_utils.py. Maybe we should align where we put these make_input stuff?
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
Reviewed By: vmoens Differential Revision: D50789086 fbshipit-source-id: 662427dbdccac525d81656195177f81ac6aaeaa7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @vfdev-5