Fix augmentation space to be uint8 compatible

[jopo666]

A simple fix that addresses #4805.

cc @vfdev-5 @datumbox

[facebook-github-bot]

Hi @jopo666!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[facebook-github-bot]

💊 CI failures summary and remediations

As of commit 88d24fd (more details on the Dr. CI page):

---

💚 💚 Looks good so far! There are no failures yet. 💚 💚

---

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[jopo666]

Maybe unit tests should also be extended to cover these types of bugs?

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[datumbox]

LGTM, thanks for fixing it.

[prabhat00155]

Thanks @jopo666! Could you also perhaps add a unit test to cover this case?

[datumbox]

@prabhat00155 What are your thoughts on testing this?

On the AutoAugmentation module we currently don't have any similar tests to check for misconfigurations of the methods and it's unclear how such a test would look like. One place we could potentially add it is on the implementation of solarize. For example we could add an assertion to ensure that the threshold is within bounds and then create a test to check the assertion is triggered:

vision/torchvision/transforms/functional_tensor.py

Lines 885 to 886 in d367a01

	inverted_img = invert(img)
	return torch.where(img >= threshold, inverted_img, img)

Probably a similar assertion is worth to be added at posterize for the number of bits.

Finally I wonder if it's worth merging this so that we cover the bug and add the tests on a follow up PR. No strong opinions, just want to make sure this bug fix will be merged. :)

[prabhat00155]

@prabhat00155 What are your thoughts on testing this?

On the AutoAugmentation module we currently don't have any similar tests to check for misconfigurations of the methods and it's unclear how such a test would look like. One place we could potentially add it is on the implementation of solarize. For example we could add an assertion to ensure that the threshold is within bounds and then create a test to check the assertion is triggered:

vision/torchvision/transforms/functional_tensor.py

Lines 885 to 886 in d367a01

	inverted_img = invert(img)
	return torch.where(img >= threshold, inverted_img, img)

Probably a similar assertion is worth to be added at posterize for the number of bits.

Finally I wonder if it's worth merging this so that we cover the bug and add the tests on a follow up PR. No strong opinions, just want to make sure this bug fix will be merged. :)

Thanks @datumbox for the explanation. Makes sense to merge this PR then. We could look at adding tests in a follow-up PR.

[datumbox]

@prabhat00155 Sounds great, thanks for the flexibility. I've created a ticket for this so that we don't forget: #4818

Feel free to merge on green CI.