Explicitly copying array in pil_to_tensor #4566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datumbox
changed the title
datumbox
approved these changes
Oct 7, 2021
NicolasHug
reviewed
Oct 7, 2021
torchvision/transforms/functional.py
Outdated
| @@ -161,6 +161,10 @@ def pil_to_tensor(pic): | |||
|
|
|||
| Returns: | |||
| Tensor: Converted image. | |||
|
|
|||
| .. note:: | |||
There was a problem hiding this comment.
Thanks for writing this note, such documentation is important
Let's also add it to to the PILToTensor transform, since it relies on pil_to_tensor.
Also, maybe put it above the Args: section for it to have better visibility?
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
NicolasHug
approved these changes
Oct 8, 2021
There was a problem hiding this comment.
Thanks @jdsgomes ! Last comment to fix the docs, but LGTM when addressed
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
datumbox
added a commit
to datumbox/vision
that referenced
this pull request
Oct 8, 2021
* mExplicitly copying array in pil_to_tensor * Update torchvision/transforms/functional.py Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> * Adding comments regarding implicit array deep copy in PILToTensor transform * Update torchvision/transforms/transforms.py Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
datumbox
added a commit
that referenced
this pull request
Oct 8, 2021
* mExplicitly copying array in pil_to_tensor * Update torchvision/transforms/functional.py Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> * Adding comments regarding implicit array deep copy in PILToTensor transform * Update torchvision/transforms/transforms.py Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com> Co-authored-by: Joao Gomes <joaopsgomes@gmail.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 8, 2021
Summary: * mExplicitly copying array in pil_to_tensor * Update torchvision/transforms/functional.py * Adding comments regarding implicit array deep copy in PILToTensor transform * Update torchvision/transforms/transforms.py Reviewed By: NicolasHug Differential Revision: D31505570 fbshipit-source-id: a2ce1c5cf6b70236bc71a79a3d190ddac7d378a4 Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
mszhanyi
pushed a commit
to mszhanyi/vision
that referenced
this pull request
Oct 19, 2021
* mExplicitly copying array in pil_to_tensor * Update torchvision/transforms/functional.py Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> * Adding comments regarding implicit array deep copy in PILToTensor transform * Update torchvision/transforms/transforms.py Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
* mExplicitly copying array in pil_to_tensor * Update torchvision/transforms/functional.py Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> * Adding comments regarding implicit array deep copy in PILToTensor transform * Update torchvision/transforms/transforms.py Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid
UserWarningwhen callingpil_to_tensorwe are making a deep copy of the underlying array when converting fromPIL ImagetoTensor.fixes #4508
cc @vfdev-5 @datumbox