rm install_cuda_compatible_cmath #4388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@malfet @NicolasHug @seemethere , It'd better to be merged soon to avoid merging conflicts with my following PR to enable CUDA tests. |
malfet
approved these changes
Sep 13, 2021
|
I can confirm the macos failures are unrelated. @seemethere I'll let you approve this one, since you introduced these changes in #3609 it seems. EDIT oh Nikita just approved, cool. I'll push the removal and merge, thanks |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 30, 2021
Summary: * rm install_cuda_compatible_cmath * Remove unused script Reviewed By: datumbox Differential Revision: D31268042 fbshipit-source-id: 1d10c04a48813a1ea4a267c1f82c69e65f3c068c Co-authored-by: Nicolas Hug <nicolashug@fb.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working reenable cuda tests in vision.
It will be splitted to multiple simple and clear PRs.
This PR is only to remove obsolete step install_cuda_compatible_cmake
cc @seemethere