Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix syntax in PR labels workflow #4012

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Jun 9, 2021

As announced in #3993 (review).

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmeier. For these I think it's fine for you to self merge without waiting for a review, if you're confident in your changes.

But regardless, I'm wondering whether this be tested on a fork first, to save you the pain of some back and forth?

@pmeier
Copy link
Collaborator Author

pmeier commented Jun 9, 2021

But regardless, I'm wondering whether this be tested on a fork first, to save you the pain of some back and forth?

Lets see if I got it right this time. If not, I'll set up something to test it there.

@pmeier pmeier merged commit a00c735 into pytorch:master Jun 9, 2021
@pmeier pmeier deleted the fix-pr-labels branch June 9, 2021 07:56
facebook-github-bot pushed a commit that referenced this pull request Jun 14, 2021
Reviewed By: fmassa

Differential Revision: D29097717

fbshipit-source-id: 1628c8da7486d134115f952fc80703e3b6af4a32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants