Port test pad in test_transforms to pytest #3954
Conversation
|
Hi @Dbhasin1! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Thanks @Dbhasin1 ! this looks great, I just think we should revert the unrelated changes, but otherwise LGTM when green!
test/test_transforms.py
Outdated
| import math | ||
| import os |
There was a problem hiding this comment.
I think your editor automatically formatted the file here. We try to avoid such unrelated changes (here and also below line 28 and line 308): they're unrelated and tend to break git blame, and can also create unnecessary conflicts with other ongoing PRs. Would you mind reverting these?
|
Thanks a lot @Dbhasin1 ! |
Reviewed By: NicolasHug Differential Revision: D29027342 fbshipit-source-id: 68c37df1ee43eaf05b3156bd6403bb1b7591912b
Refactor Group N and group the tests into a class as mentioned in #3945
test_pad
test_pad_raises_with_invalid_pad_sequence_len
test_pad_with_mode_F_images
test_pad_with_non_constant_padding_modes
test_pad_with_tuple_of_pad_values