-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use torch.testing.assert_close in test_anchor_utils.py #3880
Merged
Merged
Changes from 23 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
c4fc01b
adopt `torch.testing.assert_close` in test suite
pmeier bfbe19b
revert some changes
pmeier 09f86f4
add todo
pmeier 86402f0
flake8
pmeier 48d32e6
Hopefully fixed test_functional_tensor
NicolasHug 15b50e3
hopefully fixed test_ops
NicolasHug a54880f
Merge branch 'master' of github.com:pytorch/vision into assert-close
NicolasHug 61874ac
Fix test_utils
NicolasHug 30f20a3
revert unwanted changes to test_image
NicolasHug 3a29ae3
maybe fixed test_transforms
NicolasHug d6d73d0
Merge branch 'master' into assert-close
NicolasHug 863f144
fix test_datasets_video_utils
pmeier c8a5afa
fix test_transforms
pmeier e697e88
Merge branch 'master' into assert-close
pmeier 93614f0
flake8
pmeier 11caf01
Merge branch 'master' of github.com:pytorch/vision into assert-close
NicolasHug d7fde8c
Merge branch 'assert-close' of github.com:pmeier/vision into assert-c…
NicolasHug 0b237c7
use cu102 see if the nightlies are actual nightlies?
NicolasHug c2ace86
obviously forgot to call regenerate.py
NicolasHug d78226a
not as obvious, reverting
NicolasHug bb543a7
Merge branch 'master' into assert-close
NicolasHug 7507a0c
Merge branch 'master' into assert-close
NicolasHug a4726cb
revert everything but anchor_utils
NicolasHug c071048
Merge branch 'master' into assert_close_anchor
NicolasHug 4cd13a7
Merge branch 'master' into assert_close_anchor
NicolasHug File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here it's a bit of a shame IMHO that we're forced to specify
atol
as well. The default foratol
is 1e-5 andpasses just fine, so ideally we could just write