Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rocm4.2 to nightly wheel builds #3840

Merged
merged 4 commits into from
May 19, 2021
Merged

add rocm4.2 to nightly wheel builds #3840

merged 4 commits into from
May 19, 2021

Conversation

jeffdaily
Copy link
Contributor

No description provided.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll let @malfet or @seemethere merge

Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove older version of ROCm before adding new ones. (Or add a note why all 3 are still needed)

.circleci/regenerate.py Outdated Show resolved Hide resolved
@jeffdaily jeffdaily requested a review from malfet May 18, 2021 21:22
@jeffdaily
Copy link
Contributor Author

@malfet I removed rocm 4.0.1. Ready to merge?

@malfet
Copy link
Contributor

malfet commented May 18, 2021

@jeffdaily looks good to me, but I though that 4.1 is not going to be used in any releases, so 4.0.1 and 4.1 are they only two that should remain there?

@malfet malfet merged commit 2c52d9f into pytorch:master May 19, 2021
facebook-github-bot pushed a commit that referenced this pull request May 19, 2021
Summary:
* add rocm4.2 to nightly wheel builds

* remove rocm4.0.1 build

Reviewed By: cpuhrsch

Differential Revision: D28538752

fbshipit-source-id: 15d967486f4ae781c2eeb23d2f51c39eca6f7d26

Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
Co-authored-by: Eli Uriegas <1700823+seemethere@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants