-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add rocm4.2 to nightly wheel builds #3840
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'll let @malfet or @seemethere merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove older version of ROCm before adding new ones. (Or add a note why all 3 are still needed)
@malfet I removed rocm 4.0.1. Ready to merge? |
@jeffdaily looks good to me, but I though that 4.1 is not going to be used in any releases, so 4.0.1 and 4.1 are they only two that should remain there? |
Summary: * add rocm4.2 to nightly wheel builds * remove rocm4.0.1 build Reviewed By: cpuhrsch Differential Revision: D28538752 fbshipit-source-id: 15d967486f4ae781c2eeb23d2f51c39eca6f7d26 Co-authored-by: Francisco Massa <fvsmassa@gmail.com> Co-authored-by: Eli Uriegas <1700823+seemethere@users.noreply.github.com>
No description provided.