Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework transforms example in gallery #3744

Merged
merged 6 commits into from
Apr 28, 2021
Merged

Rework transforms example in gallery #3744

merged 6 commits into from
Apr 28, 2021
+116 −100

Conversation

NicolasHug
Copy link
Member

This PR:

  • re-organizes the example into sections, e.g. Random Transforms and Randomly-Applied transforms
  • illustrates the same transform with 4 different transformations instead of just one. This allows to showcase the random behaviour of the randomly-applied transfoms, while still setting a seed for reproducible results across runs. I think this addresses both @datumbox points and mine (see discussion Add illustrations for AutoAugment in gallery example #3727 (comment))

CI is broken so here's the rendered page:

Details

image

CC @datumbox @oke-aditya

datumbox
datumbox approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@NicolasHug NicolasHug merged commit 5ac27fe into pytorch:master Apr 28, 2021
@NicolasHug NicolasHug deleted the gallery_mulitple_columns branch April 28, 2021 09:47
facebook-github-bot pushed a commit that referenced this pull request May 4, 2021
@cpuhrsch @facebook-github-bot
[fbsync] Rework transforms example in gallery (#3744)
c64110c 
Reviewed By: NicolasHug

Differential Revision: D28169153

fbshipit-source-id: 56285dd5b39d2d53e329be3fe5fa96989eff39e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox

Assignees
No one assigned
Labels
cla signed module: documentation module: transforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NicolasHug @datumbox @facebook-github-bot