Show built doc links directly in PR GUI #3711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
changed the title
datumbox
approved these changes
Apr 22, 2021
|
thanks :)! |
|
Update: it worked \o/ #3712 |
This was referenced Apr 23, 2021
|
@NicolasHug Awesome, good one! |
|
Ugh, just FYI, github started doing this literally yesterday: https://github.blog/changelog/2021-04-22-github-actions-maintainers-must-approve-first-time-contributer-workflow-runs/ So the job won't run on PRs from new contributors until we approve it. |
|
Heads up, I just reverted this PR. It was causing crazy problems for our internal tooling due to the |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 4, 2021
Reviewed By: NicolasHug Differential Revision: D28169164 fbshipit-source-id: 30a048c1240c81abb89b033fe66a3143b83a0b80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new GitHub action that will automatically add a link to the rendered docs once the
build_docsjob is finished: https://github.com/larsoner/circleci-artifacts-redirector-actionRight now, checking the rendered docs is a bit tedious as one needs to go to the artifacts tab of the
build_docsjob, and then click on theindex.htmlfile. This will save a few clicks each time and make the rendered docs more obvious to everyone!As explained in the link above, this PR needs to be merged in
masterbefore we can even see whether it works or not.