Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paper links of VGG models #3684

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Fix paper links of VGG models #3684

merged 1 commit into from
Apr 19, 2021

Conversation

NicolasHug
Copy link
Member

Addresses part of #3681

@oke-aditya
Copy link
Contributor

Will sphinx gallery work fine with Sphinx 2.4.4 ? In #3652 you mentioned latest sphinx does it better.

@NicolasHug
Copy link
Member Author

I just tried and pushed a new commit in #3652 with 2.4.4 and yes, all seems well.
It was the really old sphinx 1.7 that we were using before that had a problem with sphinx-gallery

@oke-aditya
Copy link
Contributor

oke-aditya commented Apr 19, 2021

Great then we can stay with Sphinx 2.4.4.

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@datumbox datumbox merged commit cd1728d into pytorch:master Apr 19, 2021
facebook-github-bot pushed a commit that referenced this pull request May 4, 2021
Reviewed By: NicolasHug

Differential Revision: D28169160

fbshipit-source-id: 7118efb25f25a8d8e113a0cdade98c9f252d10b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants