New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pytorch smooth_l1_loss and remove private custom implem #3539

Merged

fmassa merged 2 commits into pytorch:master from NicolasHug:smooth_l1_loss

Mar 10, 2021

Member

NicolasHug commented Mar 10, 2021

This PR removes the custom implementation of smooth_l1_loss and uses the one from pytorch, now that it supports the beta parameter


          Use pytorch smooth_l1_loss and remove private custom implem

3ec5318

NicolasHug added module: models code quality labels

facebook-github-bot added the cla signed label

fmassa approved these changes

View reviewed changes

Member

fmassa left a comment

Thanks!


          Merge branch 'master' into smooth_l1_loss

390482f

fmassa merged commit 797fd26 into pytorch:master

facebook-github-bot pushed a commit that referenced this pull request


          [fbsync] Use pytorch smooth_l1_loss and remove private custom implem (#…

a198fc3

…3539)

Reviewed By: NicolasHug, cpuhrsch

Differential Revision: D26945725

fbshipit-source-id: c7f300b6eb54e496947cda4502bcdcd4fc1d6bc7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed code quality module: models