Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for Flickr(8|30)k datasets #3489

Merged
merged 6 commits into from
Mar 10, 2021
Merged

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Mar 2, 2021

No description provided.

@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #3489 (db7f0ce) into master (afc502b) will increase coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3489      +/-   ##
==========================================
+ Coverage   78.75%   79.30%   +0.54%     
==========================================
  Files         105      105              
  Lines        9750     9711      -39     
  Branches     1566     1555      -11     
==========================================
+ Hits         7679     7701      +22     
+ Misses       1581     1518      -63     
- Partials      490      492       +2     
Impacted Files Coverage Δ
torchvision/ops/boxes.py 87.77% <0.00%> (-3.49%) ⬇️
torchvision/transforms/functional_tensor.py 79.19% <0.00%> (-0.73%) ⬇️
torchvision/transforms/functional_pil.py 67.61% <0.00%> (-0.52%) ⬇️
torchvision/transforms/transforms.py 84.28% <0.00%> (-0.03%) ⬇️
torchvision/transforms/functional.py 81.77% <0.00%> (ø)
torchvision/datasets/utils.py 72.58% <0.00%> (+2.37%) ⬆️
torchvision/datasets/flickr.py 98.71% <0.00%> (+73.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fe439e...c941874. Read the comment docs.

@pmeier pmeier requested a review from fmassa March 3, 2021 16:27
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@fmassa fmassa merged commit 0139808 into pytorch:master Mar 10, 2021
facebook-github-bot pushed a commit that referenced this pull request Mar 10, 2021
Summary:
* add tests for Flickr8k dataset

* add tests for FLickr30k dataset

* lint

Reviewed By: NicolasHug, cpuhrsch

Differential Revision: D26945729

fbshipit-source-id: e8bae59242d72611eed607c61985ea8e309bca72

Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
@pmeier pmeier deleted the flickr-tests branch March 12, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants