add tests for LSUN #3454
Merged
add tests for LSUN #3454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
Feb 25, 2021
Comment on lines
+976
to
+978
| # Currently datasets.LSUN caches the keys in the current directory rather than in the root directory. Thus, | ||
| # this creates a number of unique _cache_* files in the current directory that will not be removed together | ||
| # with the temporary directory |
There was a problem hiding this comment.
I'll send a follow-up PR to fix this.
Codecov Report
@@ Coverage Diff @@
## master #3454 +/- ##
==========================================
- Coverage 76.13% 76.11% -0.02%
==========================================
Files 105 105
Lines 9703 9697 -6
Branches 1556 1556
==========================================
- Hits 7387 7381 -6
Misses 1836 1836
Partials 480 480
Continue to review full report at Codecov.
|
Closed
fmassa
approved these changes
Mar 1, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 4, 2021
Summary: Reviewed By: fmassa Differential Revision: D26756274 fbshipit-source-id: b489819c79dfb03393a7ee9c2638f9a5bc35c11e Co-authored-by: vfdev <vfdev.5@gmail.com> Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.