[FBCode->GH] accept python bytes in _read_video_from_memory() #3347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We accept python bytes for video in existing API, such as `_read_video_timestamps_from_memory`. We should do so to `_read_video_timestamps_from_memory` as well. Reviewed By: fmassa Differential Revision: D26216777 fbshipit-source-id: 5d7ecf15c5a65dc5c57f17b343e7c63b4933189e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We accept python bytes for video in existing API, such as
_read_video_timestamps_from_memory.We should do so to
_read_video_timestamps_from_memoryas well.Reviewed By: fmassa
Differential Revision: D26216777
fbshipit-source-id: 5d7ecf15c5a65dc5c57f17b343e7c63b4933189e