Clean up and Document io.image enhancements (#3034) #3193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…read_mode.h, replace define with const in image_read_mode.h, add documentation to ImageReadMode enum
|
Hi @Sid2697! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but we do not have a signature on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Sid2697
changed the title
datumbox
reviewed
Dec 19, 2020
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 23, 2020
Summary: * Update ImageReadMode error messages, add newline at the end of image_read_mode.h, replace define with const in image_read_mode.h, add documentation to ImageReadMode enum * Update readpng_cpu and readjpeg_cpu error messages * Update image.py documentation Reviewed By: fmassa Differential Revision: D25679209 fbshipit-source-id: 4376dbb0e005ae4a09b908daada8a5a5cfd9b2a8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3034
decode_pnganddecode_jpgas docs indecode_imageandread_imagesuggest the user to checkdecode_jpegfor the documentation. However, I have added the documentation to the enum.const.I hope this PR solves all the aforementioned issues. Do let me know if there are any concerns.