[BC-breaking] Remove _new_empty_tensor op #3156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3156 +/- ##
==========================================
+ Coverage 72.75% 72.79% +0.03%
==========================================
Files 99 98 -1
Lines 8979 8964 -15
Branches 1431 1430 -1
==========================================
- Hits 6533 6525 -8
+ Misses 1999 1992 -7
Partials 447 447
Continue to review full report at Codecov.
|
fmassa
changed the title
fmassa
approved these changes
Dec 11, 2020
| @@ -76,20 +76,6 @@ def to_numpy(tensor): | |||
| else: | |||
| raise | |||
|
|
|||
| @unittest.skip("Disable test until Split w/ zero sizes is implemented in ORT") | |||
| def test_new_empty_tensor(self): | |||
There was a problem hiding this comment.
My initial reaction was to keep this test, as it's not using the new_empty_tensor op but instead tries to enforce that nn.Conv2d support empty batch sizes (which was the original use-case for having a new_empty_tensor)
But given that this test has been disabled for a long time, let's just remove it.
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 15, 2020
Summary: Co-authored-by: Francisco Massa <fvsmassa@gmail.com> Reviewed By: datumbox Differential Revision: D25531033 fbshipit-source-id: 735bdd211edfb49bc97fae8558049214d6a4b169
This was referenced Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we merge this PR, we should clean up the single FBCode ref post merge.