Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port DeformConv to use the Dispatcher and support Autocast #2898

Merged
merged 6 commits into from
Oct 27, 2020
Merged

Port DeformConv to use the Dispatcher and support Autocast #2898

merged 6 commits into from
Oct 27, 2020

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented Oct 26, 2020 •
edited
Loading

Fixes #2833

part of #2797 and #2796

@datumbox datumbox force-pushed the feature/dispatcher_deformconv branch from f5bdd73 to ae6edbd Compare October 26, 2020 21:35
@datumbox datumbox force-pushed the feature/dispatcher_deformconv branch 3 times, most recently from c5e868d to f544463 Compare October 27, 2020 00:12
@datumbox datumbox force-pushed the feature/dispatcher_deformconv branch from f544463 to 4db0380 Compare October 27, 2020 00:16
@datumbox datumbox force-pushed the feature/dispatcher_deformconv branch from c73b8b6 to 4db0380 Compare October 27, 2020 08:57
@datumbox datumbox changed the title [WIP] Port DeformConv to use the dispatcher Port DeformConv to use the dispatcher Oct 27, 2020
@codecov
Copy link

codecov bot commented Oct 27, 2020 •
edited
Loading

Codecov Report

Merging #2898 into master will increase coverage by 1.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2898      +/-   ##
==========================================
+ Coverage   72.32%   73.51%   +1.18%     
==========================================
  Files          99       99              
  Lines        8799     8839      +40     
  Branches     1389     1400      +11     
==========================================
+ Hits         6364     6498     +134     
+ Misses       1997     1917      -80     
+ Partials      438      424      -14
Impacted Files Coverage Δ
torchvision/models/vgg.py 92.59% <0.00%> (+2.88%) ⬆️
torchvision/models/detection/rpn.py 93.86% <0.00%> (+3.68%) ⬆️
torchvision/models/detection/roi_heads.py 82.34% <0.00%> (+5.10%) ⬆️
torchvision/ops/boxes.py 95.40% <0.00%> (+8.04%) ⬆️
torchvision/ops/poolers.py 98.07% <0.00%> (+11.53%) ⬆️
torchvision/models/detection/transform.py 95.55% <0.00%> (+17.22%) ⬆️
torchvision/ops/_register_onnx_ops.py 85.36% <0.00%> (+36.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e987d1c...a3e9afa. Read the comment docs.

@datumbox datumbox requested a review from fmassa October 27, 2020 11:38
@datumbox datumbox changed the title Port DeformConv to use the dispatcher Port DeformConv to use the Dispatcher and support Autocast Oct 27, 2020
fmassa
fmassa reviewed Oct 27, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks great, thanks a lot @datumbox !

I have one comment that I think might be a bug, but I'll let @ezyang confirm.

@datumbox datumbox requested a review from fmassa October 27, 2020 13:31
@datumbox datumbox mentioned this pull request Oct 27, 2020
Merged
fmassa
fmassa approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is good to merge, thanks!

I have one question regarding Tensor&&, which I'm not used to seeing in the PyTorch codebase.

We can merge the PR as is now, but I would maybe we should check on this afterwards

@fmassa fmassa merged commit e8b6e3f into pytorch:master Oct 27, 2020
@fmassa
Copy link
Member

fmassa commented Oct 27, 2020

Thanks a lot Vasilis!

@datumbox datumbox deleted the feature/dispatcher_deformconv branch October 28, 2020 12:45
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
@datumbox @bryant1410
Port DeformConv to use the Dispatcher and support Autocast (pytorch#2898
5d3f7b6 
)

* Splitting tuples of stride, padding and dilation of DeformConv.

* Fixing types.

* Dispatcher + Autocast.

* + Autograd.

* Moving contiguous() convertions away dispatcher and into the implementations.

* Removing rvalue references.
vfdev-5 pushed a commit to Quansight/vision that referenced this pull request Dec 4, 2020
@datumbox @vfdev-5
Port DeformConv to use the Dispatcher and support Autocast (pytorch#2898
bdf653c 
)

* Splitting tuples of stride, padding and dilation of DeformConv.

* Fixing types.

* Dispatcher + Autocast.

* + Autograd.

* Moving contiguous() convertions away dispatcher and into the implementations.

* Removing rvalue references.
@NicolasHug NicolasHug mentioned this pull request Jul 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang left review comments

@mthrok mthrok mthrok left review comments

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fp16 for deform_conv2d missing?
4 participants
@datumbox @fmassa @ezyang @mthrok