Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.cirlceci: Be specific about CU_VERSION for pytorch #2827

Merged

Conversation

seemethere
Copy link
Member

@seemethere seemethere commented Oct 16, 2020

ROCM builds were being picked up for CUDA 10.2 builds since they do not
specify a version suffix. We can utilize the CU_VERSION to be specific
about which index to actually pull from.

Cherry pick to master of the fix from #2826

Signed-off-by: Eli Uriegas eliuriegas@fb.com

ROCM builds were being picked up for CUDA 10.2 builds since they do not
specify a version suffix. We can utilize the CU_VERSION to be specific
about which index to actually pull from.

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Copy link
Contributor

@xuzhao9 xuzhao9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #2827 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2827   +/-   ##
=======================================
  Coverage   73.26%   73.26%           
=======================================
  Files          99       99           
  Lines        8778     8778           
  Branches     1387     1387           
=======================================
  Hits         6431     6431           
  Misses       1920     1920           
  Partials      427      427           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b480903...d7d26cb. Read the comment docs.

@fmassa fmassa merged commit a9c78f1 into pytorch:master Oct 16, 2020
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
ROCM builds were being picked up for CUDA 10.2 builds since they do not
specify a version suffix. We can utilize the CU_VERSION to be specific
about which index to actually pull from.

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
vfdev-5 pushed a commit to Quansight/vision that referenced this pull request Dec 4, 2020
ROCM builds were being picked up for CUDA 10.2 builds since they do not
specify a version suffix. We can utilize the CU_VERSION to be specific
about which index to actually pull from.

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants