Add empty batch support for DeformConv2d #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fmassa not sure the fails are due to the changes but it's definitely worth confirming. Can we trigger a retest? |
fmassa
approved these changes
Oct 11, 2020
There was a problem hiding this comment.
The PR looks great, thanks a lot @datumbox !
The test failures seem unrelated, I'm re-running the CI to see if it was a one-off flakiness, and if it still fails I'll open an issue to fix it afterwards (as it's probably related to a upstream library change).
datumbox
changed the title
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
…#2782) * Adding checks on forward and backward passes. * Adding unit-tests.
vfdev-5
pushed a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
…#2782) * Adding checks on forward and backward passes. * Adding unit-tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support empty batch for DeformConv2d, issue #2293
cc @fmassa