Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set macro value when libpng version is invalid #2735

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

andfoy
Copy link
Contributor

@andfoy andfoy commented Sep 30, 2020

This PR properly disables PNG functionality when libpng version is less than 1.6.0

See pytorch/pytorch#45342

@andfoy andfoy self-assigned this Sep 30, 2020
@andfoy andfoy changed the title PR: Set macro value when libpng version is invalid Set macro value when libpng version is invalid Sep 30, 2020
@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #2735 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2735   +/-   ##
=======================================
  Coverage   72.93%   72.93%           
=======================================
  Files          95       95           
  Lines        8239     8239           
  Branches     1279     1279           
=======================================
  Hits         6009     6009           
  Misses       1838     1838           
  Partials      392      392           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b618923...8da8385. Read the comment docs.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit 786ec32 into pytorch:master Oct 1, 2020
@andfoy andfoy deleted the fix_png_macro_disabling branch October 1, 2020 13:58
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
vfdev-5 pushed a commit to Quansight/vision that referenced this pull request Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants