-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CONTRIBUTING.md #2663
Added CONTRIBUTING.md #2663
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2663 +/- ##
=======================================
Coverage 72.75% 72.75%
=======================================
Files 99 99
Lines 8979 8979
Branches 1431 1431
=======================================
Hits 6533 6533
Misses 1999 1999
Partials 447 447 Continue to review full report at Codecov.
|
Any chance we could merge this to master? It's a good source of info for new comers as it describes setting up the dev environment. We could continue improving it post merge. |
This is just a suggestion. Should new datasets support at a minimum, the same constructor arguments (when appropriate)?
|
dbc1f76
to
c23b205
Compare
ea71038
to
79a50f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for working on this @vfdev-5 !
Let's get this merged, and at the same time can you create an issue (or keep the existing one open) so that we track completing the points about datasets / models?
@jgbradley1 that's a good suggestion, although I'm not sure it can be generically implemented everywhere. FYI there was some discussion already in the past about dataset standardization in #1080 |
@fmassa let's keep existing issue open and I add a message about that. |
Summary: * [WIP] Added CONTRIBUTING.md * Updated CONTRIBUTING.md * Update Reviewed By: fmassa Differential Revision: D25460676 fbshipit-source-id: b28d9f5f2530363aa371b6ef7d09fa0cdb96bba9
Related #2651
Description:
This PR is not closing the issue #2651 as there are 2 sections to be defined later.
EDIT: There is already a PR submitted by the bot : #1564
I was not aware before.