Fixes crash in deformable convolutions (2598) #2604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adjusted num_kernels and batch_size according to kMaxGridNum * CUDA_NUM_THREADS - Tests to add
Codecov Report
@@ Coverage Diff @@
## master #2604 +/- ##
=======================================
Coverage 71.65% 71.65%
=======================================
Files 94 94
Lines 8121 8121
Branches 1289 1289
=======================================
Hits 5819 5819
Misses 1896 1896
Partials 406 406 Continue to review full report at Codecov.
|
vfdev-5
changed the title
- Added test to check the code from issue and compared grads CPU/CUDA
vfdev-5
force-pushed
the
vfdev-5/issue-2598
branch
from
3f115e4 to
d6fffe0
Compare
fmassa
reviewed
Aug 24, 2020
fmassa
approved these changes
Aug 24, 2020
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
* [WIP] Fixes pytorch#2598 - Adjusted num_kernels and batch_size according to kMaxGridNum * CUDA_NUM_THREADS - Tests to add * - Redefined kMaxGridNum as max grid according to current CUDA device - Added test to check the code from issue and compared grads CPU/CUDA * Fixed static kMaxGridNum evaluation to dynamic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2598
Description:
[x] Adjustednum_kernelsandbatch_sizeaccording tokMaxGridNum * CUDA_NUM_THREADSkMaxGridNumas max grid according to current CUDA deviceThis PR adjustsnum_kernelsandbatch_sizeto avoid the situation such thatnum_kernels>kMaxGridNum * CUDA_NUM_THREADS. If it is not possible to adjustbatch_size(e.g. batch_size=0), an exception is raised.