make convert_image_dtype scriptable #2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nairbv
commented
Jul 17, 2020
nairbv
commented
Jul 17, 2020
nairbv
commented
Jul 17, 2020
nairbv
force-pushed
the
scriptable_dtype_conversion
branch
from
c8c30da to
794bbb1
Compare
nairbv
force-pushed
the
scriptable_dtype_conversion
branch
from
bde5973 to
f610463
Compare
nairbv
commented
Jul 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #2485 +/- ##
==========================================
- Coverage 73.07% 72.95% -0.12%
==========================================
Files 96 96
Lines 8304 8319 +15
Branches 1292 1293 +1
==========================================
+ Hits 6068 6069 +1
- Misses 1838 1850 +12
- Partials 398 400 +2
Continue to review full report at Codecov.
|
|
@pmeier yes, let's move forward with this PR, thanks a lot for working on that other PR! |
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
* make convert_image_dtype scriptable * move convert dtype to functional_tensor since only works on tensors * retain availability of convert_image_dtype in functional.py * Update code and tests * Replaced int by torch.dtype * int -> torch.dtype and use F instead of F_t * Update functional_tensor.py Co-authored-by: vfdev-5 <vfdev.5@gmail.com>
vfdev-5
added a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
* make convert_image_dtype scriptable * move convert dtype to functional_tensor since only works on tensors * retain availability of convert_image_dtype in functional.py * Update code and tests * Replaced int by torch.dtype * int -> torch.dtype and use F instead of F_t * Update functional_tensor.py Co-authored-by: vfdev-5 <vfdev.5@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is a good idea since it might be slower, but wanted to see if I could make convert_image_dtype scriptable.
iinfo isn't supported by torchscript: pytorch/pytorch#41492
This PR also moves convert_image_dtype to functional_tensor since it only applies to tensor ops, and because functional_tensor can't import from functional.