For std::min and std::max cast to like data types #2389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Kriske <kriske_jeffery_e@lilly.com>
Codecov Report
@@ Coverage Diff @@
## master #2389 +/- ##
=======================================
Coverage 70.69% 70.69%
=======================================
Files 94 94
Lines 7839 7839
Branches 1221 1221
=======================================
Hits 5542 5542
Misses 1925 1925
Partials 372 372 Continue to review full report at Codecov.
|
de-vri-es
pushed a commit
to fizyr-forks/torchvision
that referenced
this pull request
Aug 4, 2020
Signed-off-by: Jeff Kriske <kriske_jeffery_e@lilly.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Casting to size_t to comply with std library min and max template requirements that the types should match instead of relying on the compiler to figure it out.
Since size_t can be many data types, depending on the architecture and compiler, this change should hopefully ensure it is correct.