-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port TorchRL tutorial for DDPG Loss to pytorch.org #2413
Merged
Merged
Changes from 18 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
1b2f520
Port TorchRL tutorial for DDPG Loss to pytorch.org
nairbv 95d7b1c
some stylistic changes, e.g. UK->US
nairbv 871f50b
capitalize CUDA
nairbv 09840d0
they / They
nairbv 67f25c6
update URL format
nairbv 22f5555
Apply suggestions from code review
nairbv 8bcd15c
Merge branch 'main' into add_coding_ddpg
ecf0b6e
workaround pyspell errors
nairbv 60ffc17
fix some more pyspell issues
nairbv f14df96
fix a ci failure
nairbv 41fbe38
adding "next steps" section
nairbv d48f073
Merge branch 'main' into add_coding_ddpg
1b1bfc1
cleanup more typos
nairbv fdc6653
Merge branch 'main' into add_coding_ddpg
nairbv 3a21bca
add early import of torchrl to avoid conflicts on mp.set_start_method
nairbv b4d74d5
Merge branch 'main' into add_coding_ddpg
nairbv 2e946ea
try again on fixing multiproc spawn issue, couldnt repro locally
nairbv 7ba9abd
Merge branch 'main' into add_coding_ddpg
nairbv d756188
Apply suggestions from code review
271e5d3
Update intermediate_source/coding_ddpg.py
b575982
Merge branch 'main' into add_coding_ddpg
7c48bff
Update intermediate_source/coding_ddpg.py
ed57fca
fix
vmoens b878abd
Merge branch 'main' into add_coding_ddpg
vmoens 425a694
SyncDataCollector
vmoens 1263c60
SyncDataCollector
vmoens f4a5e4b
Merge branch 'main' into add_coding_ddpg
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add:
rollouts
rollout
Ornstein
Uhlenbeck
OU
This should be enough to pass the spellcheck after merging other suggestions