Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] relax the FP8 CUDA arch limitation to SM89 #549

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

leeeizhang
Copy link
Contributor

@leeeizhang leeeizhang commented Aug 21, 2024

closes: #548

Nvidia Ada Lovelace GPUs (e.g., RTX 4090, L20, L40) with SM89 version are also support FP8 MMA, and hence, it is recommended to relax the CUDA architecture limitations to enable FP8 training on a broader range of devices.

and the CUDA 12.0 announcement says that it supports Lovelace architecture:
'CUDA 12.0 exposes programmable functionality for many features of the NVIDIA Hopper and NVIDIA Ada Lovelace architectures: ...32x Ultra xMMA (including FP8 and FP16)'

image

After relaxing the CUDA architecture limitations for FP8, my environment with 4 x L40 GPUs (SM89) can still successfully train llama under float8 precision.

image

@facebook-github-bot
Copy link

Hi @leeeizhang!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@leeeizhang leeeizhang changed the title [WIP] relax the FP8 CUDA arch limitation to SM89 [MRG] relax the FP8 CUDA arch limitation to SM89 Aug 21, 2024
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 21, 2024
torchtitan/float8.py Outdated Show resolved Hide resolved
Co-authored-by: Andrew Gu <31054793+awgu@users.noreply.github.com>
Copy link
Contributor

@awgu awgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@awgu awgu merged commit 90c889e into pytorch:main Aug 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FP8] Relax the FP8 cuda arch limitation for NVIDIA Ada GPUs (SM89)
3 participants