Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for PP tracer frontend #357

Merged
merged 2 commits into from
May 24, 2024
Merged

Conversation

wconstab
Copy link
Contributor

@wconstab wconstab commented May 23, 2024

Stack from ghstack (oldest at bottom):


  • switch to using public PipelineStage API
  • clean up some asserts in tracer codepath

[ghstack-poisoned]
wconstab added a commit that referenced this pull request May 23, 2024
- switch to using public PipelineStage API
- clean up some asserts in tracer codepath

ghstack-source-id: b7986a35349bbf97bf363ed7024a86fce8028be8
Pull Request resolved: #357
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label May 23, 2024
Copy link
Contributor

@kwen2501 kwen2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up the path!

[ghstack-poisoned]
wconstab added a commit that referenced this pull request May 24, 2024
- switch to using public PipelineStage API
- clean up some asserts in tracer codepath

ghstack-source-id: 2d069b7d45c4f3c788dec8fc85d8a7e83e463fcd
Pull Request resolved: #357
@wconstab wconstab merged commit a1b31fa into gh/wconstab/27/base May 24, 2024
4 checks passed
wconstab added a commit that referenced this pull request May 24, 2024
- switch to using public PipelineStage API
- clean up some asserts in tracer codepath

ghstack-source-id: 2d069b7d45c4f3c788dec8fc85d8a7e83e463fcd
Pull Request resolved: #357
@wconstab wconstab deleted the gh/wconstab/27/head branch May 24, 2024 17:11
tianyu-l pushed a commit that referenced this pull request May 28, 2024
- switch to using public PipelineStage API
- clean up some asserts in tracer codepath

ghstack-source-id: 2d069b7d45c4f3c788dec8fc85d8a7e83e463fcd
Pull Request resolved: #357
tianyu-l pushed a commit to tianyu-l/torchtitan_intern24 that referenced this pull request Aug 16, 2024
- switch to using public PipelineStage API
- clean up some asserts in tracer codepath

ghstack-source-id: 2d069b7d45c4f3c788dec8fc85d8a7e83e463fcd
Pull Request resolved: pytorch#357
tianyu-l pushed a commit that referenced this pull request Aug 16, 2024
- switch to using public PipelineStage API
- clean up some asserts in tracer codepath

ghstack-source-id: 2d069b7d45c4f3c788dec8fc85d8a7e83e463fcd
Pull Request resolved: #357
tianyu-l pushed a commit that referenced this pull request Aug 16, 2024
- switch to using public PipelineStage API
- clean up some asserts in tracer codepath

ghstack-source-id: 2d069b7d45c4f3c788dec8fc85d8a7e83e463fcd
Pull Request resolved: #357
philippguevorguian pushed a commit to YerevaNN/YNNtitan that referenced this pull request Aug 17, 2024
- switch to using public PipelineStage API
- clean up some asserts in tracer codepath

ghstack-source-id: 2d069b7d45c4f3c788dec8fc85d8a7e83e463fcd
Pull Request resolved: pytorch#357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants