Support quaternary UDFs #296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D35734665 |
Summary: Pull Request resolved: pytorch#296 To unblock pytorch#288 . We should invest how to support varags, instead of hard code arity. Reviewed By: OswinC Differential Revision: D35734665 fbshipit-source-id: 9f804dafdfc5fb5edc9364b5fb457e50d6afe707
|
This pull request was exported from Phabricator. Differential Revision: D35734665 |
wenleix
force-pushed
the
export-D35734665
branch
from
9ebb3e1
to
862041d
Compare
YLGH
pushed a commit
to YLGH/torcharrow
that referenced
this pull request
May 7, 2022
Summary: Pull Request resolved: pytorch/torchrec#296 Remove item call, consolidate into a single D->H. Saves ~3-4ms. (7ms -> 3ms) Reviewed By: xing-liu, bigning Differential Revision: D36169646 fbshipit-source-id: 02d27ed792ce19d16b99621c36ba11764c2d9ffe
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D35734665