Enable non-org autoscaler to read scale-config from any repo #5767
+121
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
facebook-github-bot
added
the
CLA Signed
jeanschmidt
reviewed
Oct 16, 2024
| @@ -60,7 +60,7 @@ export async function scaleUp( | |||
| const runnerTypes = await getRunnerTypes( | |||
| { | |||
| owner: repo.owner, | |||
| repo: Config.Instance.enableOrganizationRunners ? Config.Instance.scaleConfigRepo : repo.repo, | |||
| repo: Config.Instance.scaleConfigRepo || repo.repo, | |||
There was a problem hiding this comment.
extra space before Config :)
jeanschmidt
reviewed
Oct 16, 2024
terraform-aws-github-runner/modules/runners/lambdas/runners/src/scale-runners/scale-up.ts
Outdated
Show resolved
Hide resolved
|
Overall I do like the approach :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable putting scale-config in test-infra, even for non-organization runners.
Significant change:
scale_config_repono longer defaults to test-infra. You now have to specify a value if you're using org runners. Non-org runners will default to the job's repo. pytorch-gha-infra and ci-infra will need to be updated accordingly.TODO: Validate tests