Add min-available runners to scale-config #5713
Conversation
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
zxiiro
force-pushed
the
zxiiro/min-runners
branch
2 times, most recently
from
140d43b
to
23f523f
Compare
...aform-aws-github-runner/modules/runners/lambdas/runners/src/scale-runners/gh-runners.test.ts
Outdated
Show resolved
Hide resolved
| const repo: Repo = (() => { | ||
| if (Config.Instance.enableOrganizationRunners) { | ||
| return { | ||
| owner: ec2runner.org !== undefined ? (ec2runner.org as string) : getRepo(ec2runner.repo as string).owner, | ||
| repo: Config.Instance.scaleConfigRepo, | ||
| }; | ||
| } | ||
| return getRepo(ec2runner.repo as string); | ||
| })(); |
There was a problem hiding this comment.
Why does this have to be put inside a temporary lambda that's immediately invoked?
There was a problem hiding this comment.
I'm a Typescript newbie so I'm not really sure myself, I used another function as a template that I copied from. I'll work on removing the temporary lambda function.
There was a problem hiding this comment.
So the isEphemeralRunner() function above this uses the same code which I copied from. I'm inclined to keep it the same since it works. Maybe we can update both functions as an improvement in a separate pull request if we want to unravel the lambda.
Okay I'll work on adding a test for the new function. |
zxiiro
force-pushed
the
zxiiro/min-runners
branch
from
23f523f
to
bf39765
Compare
This change allows the min-available runners to be configured more specifically by the runner type rather than as a single global setting. Issue: pytorch/ci-infra#275 Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
zxiiro
force-pushed
the
zxiiro/min-runners
branch
from
bf39765
to
0034eb8
Compare
This change allows the min-available runners to be configured more specifically by the runner type rather than as a single global setting.
Issue: pytorch/ci-infra#275