Add the option to upload a selected list of CUDA arch to pypi #5217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
facebook-github-bot
added
the
CLA Signed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
seemethere
approved these changes
May 20, 2024
There was a problem hiding this comment.
I am generally okay with this but perhaps it might be good in the future to think about splitting these functionalities into their own re-usable actions so people can use them piece meal instead of part of the bigger workflow.
I think building more and more functionality into a singular happy path workflow makes it difficult for it to be flexible enough to support everything well
huydhn
added a commit
to pytorch/ao
that referenced
this pull request
May 20, 2024
huydhn
added a commit
to pytorch/ao
that referenced
this pull request
May 20, 2024
* Add nightly build workflow * Fix wrong env script path * Install pip deps * Try to install gxx_linux-64 and gcc_linux-64 * Another attempt * Set TORCH_CUDA_ARCH_LIST * Does this work? * Attempt to upload to pypi * Pass the arch * Try pypa/gh-action-pypi-publish@release/v1 * Wrong workflow syntax * Try auditwheel * Repair wheel manylinux2014_x86_64 * Debug * Debug * Almost there * Debug * Almost there * Pass -y to uninstall * Final testing * Upload other python versions * Remove debug * Remove build.yml * Add more validations * Run all unit tests * Fix typo * Run only test_ops * Passing the secrets * Move pypi upload to test-infra * Enable CPU build * Switch back to main after landing pytorch/test-infra#5217 * Remove unrelated copy/paste comments
huydhn
added a commit
that referenced
this pull request
May 21, 2024
A follow-up after #5217 and pytorch/ao#250, repo like `torch/ao` doesn't have a nightly branch and build nightly directly out of main on a daily schedule.
huydhn
added a commit
that referenced
this pull request
May 22, 2024
A follow-up after #5217 and pytorch/ao#250, repo like torch/ao doesn't have a nightly branch and build nightly directly out of main on a daily schedule. This was missed in #5222. It's a bit tricky to get this right off the bat. Also need to land D57657633 to allow nightly upload on the AWS side.
dbyoung18
pushed a commit
to dbyoung18/ao
that referenced
this pull request
Jul 31, 2024
* Add nightly build workflow * Fix wrong env script path * Install pip deps * Try to install gxx_linux-64 and gcc_linux-64 * Another attempt * Set TORCH_CUDA_ARCH_LIST * Does this work? * Attempt to upload to pypi * Pass the arch * Try pypa/gh-action-pypi-publish@release/v1 * Wrong workflow syntax * Try auditwheel * Repair wheel manylinux2014_x86_64 * Debug * Debug * Almost there * Debug * Almost there * Pass -y to uninstall * Final testing * Upload other python versions * Remove debug * Remove build.yml * Add more validations * Run all unit tests * Fix typo * Run only test_ops * Passing the secrets * Move pypi upload to test-infra * Enable CPU build * Switch back to main after landing pytorch/test-infra#5217 * Remove unrelated copy/paste comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support torchao use case where it uploads 12.1 CUDA nightly build to https://pypi.org/project/torchao-nightly
Testing
Do some testing on torchao pytorch/ao#250: