Remove special cases for torchaudio FFmpeg #4358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
facebook-github-bot
added
the
CLA Signed
mthrok
changed the title
facebook-github-bot
pushed a commit
to pytorch/audio
that referenced
this pull request
Jul 10, 2023
Summary: 1. Update smoke test script to change directory so that there is no `torchaudio` directory in CWD when smoke test is being executed. 2. Disable the part of smoke test which requires FFmpeg for wheel. The preparation for pytorch/test-infra#4358 Pull Request resolved: #3465 Reviewed By: nateanl Differential Revision: D47345117 Pulled By: mthrok fbshipit-source-id: 95aad0a22922d44ee9a24a05d9ece85166b8c17e
pytorch/audio#3460 changed the way torchaudio is built, and there is no longer need to supply FFmepg externally. test-infra no longer needs to build FFmpeg and use pre/post-scripts for torchaudio. The only issue remaining for now is smoke test. Currently torchaudio's smoke test script by default expects that FFmpeg libraries are available. This can be disabled with `--no-ffmpeg`, but the way YML files are written in test-infra repo does not allow to pass a flag to smoke test. We can switch the behavior, or use other smoke test.
mthrok
force-pushed
the
remove-ffmpeg-special-handling
branch
from
3bd382b
to
87673d9
Compare
mthrok
added a commit
to pytorch/audio
that referenced
this pull request
Jul 10, 2023
Now that we do not build FFmpeg as part of CI build process, we can remove the pre/post build scripts. Needs to land after pytorch/test-infra#4358
mthrok
changed the title
osalpekar
approved these changes
Jul 11, 2023
atalman
approved these changes
Jul 11, 2023
mthrok
added a commit
to pytorch/audio
that referenced
this pull request
Jul 11, 2023
Now that we do not build FFmpeg as part of CI build process, we can remove the pre/post build scripts. Needs to land after pytorch/test-infra#4358
facebook-github-bot
pushed a commit
to pytorch/audio
that referenced
this pull request
Jul 11, 2023
Summary: Now that we do not build FFmpeg as part of CI build process, we can remove the pre/post build scripts. Needs to land after pytorch/test-infra#4358 Pull Request resolved: #3466 Reviewed By: atalman Differential Revision: D47367022 Pulled By: mthrok fbshipit-source-id: 17aafff74ee7d269236cffb8a88c803a8d4c44b7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes all the code related to FFmpeg, which are specific to torchaudio.
pytorch/audio#3460 changed the way torchaudio is built. FFmpeg integration is handled automatically and enabled by default. This eliminates the need to supply FFmepg externally. test-infra no longer needs to build FFmpeg and use pre/post-scripts for torchaudio.
Note that smoke test was updated in pytorch/audio#3465 to not use FFmpeg for wheel.
We will revisit this later with multiple FFmpeg version support.