DrCI should never classify failure to run a workflow as flaky #4987
Assignees
Comments
This was referenced Mar 12, 2024
huydhn
added a commit
that referenced
this issue
Mar 12, 2024
Fixes #4987 Dr.CI logic to detect `isInfraFlakyJob` and `isLogClassifierFailed` has a FP where it misclassifies the GH failure to dispatch the whole workflow as flaky, for example pytorch/pytorch#121317. These logic should only be applicable to workflow job, not workflow run. The way to separate them is to check the `workflowId` field where it is set to `null` whenever it is a workflow run. ### Testing Unit test + local curl command will mark them as legit failures: ``` curl --request POST \ --url "http://localhost:3000/api/drci/drci?prNumber=121317" \ --header "Authorization: TOKEN" \ --data 'repo=pytorch' ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From pytorch/pytorch#121323 DrCI error message:
Which I guess references following failed attempt to run the workflow: https://github.com/pytorch/pytorch/actions/runs/8176971490
Those types of failures should really be merge blocking
The text was updated successfully, but these errors were encountered: