Use rocm images for rocm validations and set devtoolset correctly sim…

…ilar to xpu (#6080)
pytorch · Dec 17, 2024 · f6c5d6d · f6c5d6d
1 parent baa135f
commit f6c5d6d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.github/scripts/validate_binaries.sh b/.github/scripts/validate_binaries.sh
@@ -78,8 +78,13 @@ else
 
     pushd ${PWD}/.ci/pytorch/
 
-    if [[ ${MATRIX_GPU_ARCH_VERSION} == "12.6" || ${MATRIX_GPU_ARCH_TYPE} == "xpu" ]]; then
+    if [[ ${MATRIX_GPU_ARCH_VERSION} == "12.6" || ${MATRIX_GPU_ARCH_TYPE} == "xpu" || ${MATRIX_GPU_ARCH_TYPE} == "rocm" ]]; then
         export DESIRED_DEVTOOLSET="cxx11-abi"
+
+        # TODO: enable torch-compile on ROCM 
+        if [[ ${MATRIX_GPU_ARCH_TYPE} == "rocm" ]]; then
+            TEST_SUFFIX=${TEST_SUFFIX}" --torch-compile-check disabled"
+        fi
     fi
 
     if [[ ${TARGET_OS} == 'linux' ]]; then

diff --git a/.github/workflows/validate-linux-binaries.yml b/.github/workflows/validate-linux-binaries.yml
@@ -134,7 +134,7 @@ jobs:
       repository: "pytorch/pytorch"
       ref: main
       job-name: ${{ matrix.build_name }}
-      docker-image: ${{ (matrix.gpu_arch_type == 'xpu' && matrix.container_image) || (matrix.gpu_arch_version == '12.6' && 'pytorch/almalinux-builder:cpu-main') || 'pytorch/conda-builder' }}
+      docker-image: ${{ ((matrix.gpu_arch_type == 'xpu' || matrix.gpu_arch_type == 'rocm') && matrix.container_image) || (matrix.gpu_arch_version == '12.6' && 'pytorch/almalinux-builder:cpu-main') || 'pytorch/conda-builder' }}
       binary-matrix: ${{ toJSON(matrix) }}
       docker-build-dir: "skip-docker-build"
       timeout: 180