Skip to content

Commit

Permalink
Add submodule input for build_wheels_*.yaml (#5095)
Browse files Browse the repository at this point in the history
Let users of `build_wheels_*.yml` override the `submodules` input of
`setup-binary-build`.

pytorch/executorch does not need (or want) to do a full recursive
submodule checkout.
  • Loading branch information
dbort committed Apr 12, 2024
1 parent 7f15788 commit b1306e8
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 1 deletion.
8 changes: 7 additions & 1 deletion .github/workflows/build_wheels_linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,14 @@ on:
required: false
type: string
default: x86_64
setup-miniconda:
submodules:
description: Works as stated in actions/checkout, but the default value is recursive
required: false
type: string
default: recursive
setup-miniconda:
description: Set to true if setup-miniconda is needed
required: false
type: boolean
default: true

Expand Down Expand Up @@ -142,6 +147,7 @@ jobs:
with:
repository: ${{ inputs.repository }}
ref: ${{ inputs.ref }}
submodules: ${{ inputs.submodules }}
setup-miniconda: ${{ inputs.setup-miniconda }}
python-version: ${{ env.PYTHON_VERSION }}
cuda-version: ${{ env.CU_VERSION }}
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/build_wheels_macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@ on:
description: "The key created when saving a cache and the key used to search for a cache."
default: ""
type: string
submodules:
description: "Works as stated in actions/checkout, but the default value is recursive"
required: false
type: string
default: recursive

permissions:
id-token: write
Expand Down Expand Up @@ -105,6 +110,7 @@ jobs:
with:
repository: ${{ inputs.repository }}
ref: ${{ inputs.ref }}
submodules: ${{ inputs.submodules }}
setup-miniconda: false
python-version: ${{ env.PYTHON_VERSION }}
cuda-version: ${{ env.CU_VERSION }}
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/build_wheels_windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@ on:
description: "The key created when saving a cache and the key used to search for a cache."
default: ""
type: string
submodules:
description: "Works as stated in actions/checkout, but the default value is recursive"
required: false
type: string
default: recursive

permissions:
id-token: write
Expand Down Expand Up @@ -111,6 +116,7 @@ jobs:
with:
repository: ${{ inputs.repository }}
ref: ${{ inputs.ref }}
submodules: ${{ inputs.submodules }}
setup-miniconda: false
python-version: ${{ env.PYTHON_VERSION }}
cuda-version: ${{ env.CU_VERSION }}
Expand Down

0 comments on commit b1306e8

Please sign in to comment.