Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix colab in tutos #757

Merged
merged 1 commit into from
Apr 25, 2024
Merged

[BugFix] Fix colab in tutos #757

merged 1 commit into from
Apr 25, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Apr 25, 2024

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 25, 2024
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 127. Improved: $\large\color{#35bf28}8$. Worsened: $\large\color{#d91a1a}13$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_plain_set_nested 45.0950μs 17.7261μs 56.4139 KOps/s 58.7062 KOps/s $\color{#d91a1a}-3.90\%$
test_plain_set_stack_nested 44.5130μs 17.9230μs 55.7942 KOps/s 57.9884 KOps/s $\color{#d91a1a}-3.78\%$
test_plain_set_nested_inplace 56.4450μs 19.8118μs 50.4749 KOps/s 51.5697 KOps/s $\color{#d91a1a}-2.12\%$
test_plain_set_stack_nested_inplace 52.4690μs 19.9066μs 50.2346 KOps/s 51.5109 KOps/s $\color{#d91a1a}-2.48\%$
test_items 20.5180μs 2.5162μs 397.4317 KOps/s 405.6727 KOps/s $\color{#d91a1a}-2.03\%$
test_items_nested 1.0479ms 0.2799ms 3.5722 KOps/s 3.7763 KOps/s $\textbf{\color{#d91a1a}-5.41\%}$
test_items_nested_locked 0.5449ms 0.2764ms 3.6180 KOps/s 3.7404 KOps/s $\color{#d91a1a}-3.27\%$
test_items_nested_leaf 0.1345ms 75.6223μs 13.2236 KOps/s 13.0937 KOps/s $\color{#35bf28}+0.99\%$
test_items_stack_nested 0.5084ms 0.2758ms 3.6260 KOps/s 3.8138 KOps/s $\color{#d91a1a}-4.92\%$
test_items_stack_nested_leaf 0.6794ms 81.9612μs 12.2009 KOps/s 12.7642 KOps/s $\color{#d91a1a}-4.41\%$
test_items_stack_nested_locked 0.5072ms 0.2744ms 3.6437 KOps/s 3.7414 KOps/s $\color{#d91a1a}-2.61\%$
test_keys 36.4980μs 4.2028μs 237.9374 KOps/s 259.3777 KOps/s $\textbf{\color{#d91a1a}-8.27\%}$
test_keys_nested 0.2878ms 0.1367ms 7.3135 KOps/s 7.2228 KOps/s $\color{#35bf28}+1.26\%$
test_keys_nested_locked 1.9238ms 0.1414ms 7.0697 KOps/s 6.9903 KOps/s $\color{#35bf28}+1.14\%$
test_keys_nested_leaf 0.2039ms 0.1169ms 8.5534 KOps/s 8.5702 KOps/s $\color{#d91a1a}-0.20\%$
test_keys_stack_nested 0.2527ms 0.1372ms 7.2894 KOps/s 7.2070 KOps/s $\color{#35bf28}+1.14\%$
test_keys_stack_nested_leaf 0.1960ms 0.1156ms 8.6511 KOps/s 8.4880 KOps/s $\color{#35bf28}+1.92\%$
test_keys_stack_nested_locked 0.2357ms 0.1413ms 7.0758 KOps/s 6.9709 KOps/s $\color{#35bf28}+1.50\%$
test_values 9.2497μs 1.1637μs 859.3193 KOps/s 831.7908 KOps/s $\color{#35bf28}+3.31\%$
test_values_nested 99.4960μs 51.2474μs 19.5132 KOps/s 19.7213 KOps/s $\color{#d91a1a}-1.06\%$
test_values_nested_locked 91.8520μs 50.7648μs 19.6987 KOps/s 19.5921 KOps/s $\color{#35bf28}+0.54\%$
test_values_nested_leaf 0.1898ms 45.8318μs 21.8189 KOps/s 21.5459 KOps/s $\color{#35bf28}+1.27\%$
test_values_stack_nested 91.8310μs 51.4036μs 19.4539 KOps/s 19.6019 KOps/s $\color{#d91a1a}-0.76\%$
test_values_stack_nested_leaf 90.6690μs 45.8860μs 21.7931 KOps/s 21.4565 KOps/s $\color{#35bf28}+1.57\%$
test_values_stack_nested_locked 90.0980μs 51.1579μs 19.5473 KOps/s 19.6372 KOps/s $\color{#d91a1a}-0.46\%$
test_membership 21.6210μs 1.3828μs 723.1563 KOps/s 739.9947 KOps/s $\color{#d91a1a}-2.28\%$
test_membership_nested 23.6350μs 3.4081μs 293.4178 KOps/s 294.1745 KOps/s $\color{#d91a1a}-0.26\%$
test_membership_nested_leaf 23.8650μs 3.4358μs 291.0516 KOps/s 291.3954 KOps/s $\color{#d91a1a}-0.12\%$
test_membership_stacked_nested 23.7950μs 3.4395μs 290.7386 KOps/s 290.9507 KOps/s $\color{#d91a1a}-0.07\%$
test_membership_stacked_nested_leaf 23.5940μs 3.4039μs 293.7839 KOps/s 290.0818 KOps/s $\color{#35bf28}+1.28\%$
test_membership_nested_last 28.3940μs 4.1825μs 239.0898 KOps/s 213.6638 KOps/s $\textbf{\color{#35bf28}+11.90\%}$
test_membership_nested_leaf_last 31.8090μs 4.2093μs 237.5714 KOps/s 237.0690 KOps/s $\color{#35bf28}+0.21\%$
test_membership_stacked_nested_last 49.3220μs 4.6561μs 214.7724 KOps/s 235.2218 KOps/s $\textbf{\color{#d91a1a}-8.69\%}$
test_membership_stacked_nested_leaf_last 37.4800μs 4.2475μs 235.4352 KOps/s 236.7459 KOps/s $\color{#d91a1a}-0.55\%$
test_nested_getleaf 35.9580μs 10.6230μs 94.1353 KOps/s 92.9693 KOps/s $\color{#35bf28}+1.25\%$
test_nested_get 27.9320μs 10.0773μs 99.2330 KOps/s 98.1953 KOps/s $\color{#35bf28}+1.06\%$
test_stacked_getleaf 37.7700μs 10.5949μs 94.3854 KOps/s 94.4146 KOps/s $\color{#d91a1a}-0.03\%$
test_stacked_get 30.5870μs 10.0974μs 99.0349 KOps/s 97.3115 KOps/s $\color{#35bf28}+1.77\%$
test_nested_getitemleaf 33.4320μs 11.2309μs 89.0398 KOps/s 87.5227 KOps/s $\color{#35bf28}+1.73\%$
test_nested_getitem 37.0090μs 10.2886μs 97.1953 KOps/s 94.8432 KOps/s $\color{#35bf28}+2.48\%$
test_stacked_getitemleaf 32.5500μs 11.0881μs 90.1868 KOps/s 86.4853 KOps/s $\color{#35bf28}+4.28\%$
test_stacked_getitem 33.5730μs 10.2240μs 97.8089 KOps/s 93.4663 KOps/s $\color{#35bf28}+4.65\%$
test_lock_nested 50.3940ms 0.3992ms 2.5049 KOps/s 2.7787 KOps/s $\textbf{\color{#d91a1a}-9.85\%}$
test_lock_stack_nested 0.6435ms 0.3089ms 3.2375 KOps/s 3.1106 KOps/s $\color{#35bf28}+4.08\%$
test_unlock_nested 0.8116ms 0.3494ms 2.8623 KOps/s 2.4548 KOps/s $\textbf{\color{#35bf28}+16.60\%}$
test_unlock_stack_nested 0.5160ms 0.3164ms 3.1601 KOps/s 3.0424 KOps/s $\color{#35bf28}+3.87\%$
test_flatten_speed 0.1812ms 96.0618μs 10.4100 KOps/s 10.4119 KOps/s $\color{#d91a1a}-0.02\%$
test_unflatten_speed 0.8637ms 0.4118ms 2.4282 KOps/s 2.4122 KOps/s $\color{#35bf28}+0.66\%$
test_common_ops 3.5875ms 0.7366ms 1.3575 KOps/s 1.4139 KOps/s $\color{#d91a1a}-3.98\%$
test_creation 38.4810μs 1.8845μs 530.6559 KOps/s 508.3663 KOps/s $\color{#35bf28}+4.38\%$
test_creation_empty 39.4840μs 11.8329μs 84.5099 KOps/s 96.8988 KOps/s $\textbf{\color{#d91a1a}-12.79\%}$
test_creation_nested_1 45.8050μs 14.2950μs 69.9545 KOps/s 75.1532 KOps/s $\textbf{\color{#d91a1a}-6.92\%}$
test_creation_nested_2 64.4500μs 17.6411μs 56.6857 KOps/s 59.9574 KOps/s $\textbf{\color{#d91a1a}-5.46\%}$
test_clone 0.1216ms 13.6176μs 73.4346 KOps/s 72.8698 KOps/s $\color{#35bf28}+0.78\%$
test_getitem[int] 32.9110μs 11.4954μs 86.9914 KOps/s 85.8350 KOps/s $\color{#35bf28}+1.35\%$
test_getitem[slice_int] 56.1450μs 23.3045μs 42.9102 KOps/s 43.2118 KOps/s $\color{#d91a1a}-0.70\%$
test_getitem[range] 80.4410μs 58.0726μs 17.2198 KOps/s 17.0487 KOps/s $\color{#35bf28}+1.00\%$
test_getitem[tuple] 63.8990μs 18.8831μs 52.9575 KOps/s 51.9716 KOps/s $\color{#35bf28}+1.90\%$
test_getitem[list] 0.1086ms 40.7829μs 24.5201 KOps/s 25.1108 KOps/s $\color{#d91a1a}-2.35\%$
test_setitem_dim[int] 57.4970μs 35.5246μs 28.1495 KOps/s 29.6343 KOps/s $\textbf{\color{#d91a1a}-5.01\%}$
test_setitem_dim[slice_int] 0.1153ms 63.5512μs 15.7354 KOps/s 16.7502 KOps/s $\textbf{\color{#d91a1a}-6.06\%}$
test_setitem_dim[range] 0.1556ms 84.4970μs 11.8347 KOps/s 11.9830 KOps/s $\color{#d91a1a}-1.24\%$
test_setitem_dim[tuple] 70.3410μs 51.5759μs 19.3889 KOps/s 20.3253 KOps/s $\color{#d91a1a}-4.61\%$
test_setitem 98.6040μs 21.0229μs 47.5671 KOps/s 49.9906 KOps/s $\color{#d91a1a}-4.85\%$
test_set 62.3360μs 20.7209μs 48.2603 KOps/s 51.3738 KOps/s $\textbf{\color{#d91a1a}-6.06\%}$
test_set_shared 3.3124ms 0.1438ms 6.9552 KOps/s 7.0814 KOps/s $\color{#d91a1a}-1.78\%$
test_update 0.1277ms 23.1319μs 43.2303 KOps/s 46.5231 KOps/s $\textbf{\color{#d91a1a}-7.08\%}$
test_update_nested 0.1032ms 31.3140μs 31.9346 KOps/s 33.9311 KOps/s $\textbf{\color{#d91a1a}-5.88\%}$
test_update__nested 68.7990μs 25.0422μs 39.9326 KOps/s 38.7612 KOps/s $\color{#35bf28}+3.02\%$
test_set_nested 71.2940μs 22.3651μs 44.7125 KOps/s 45.9570 KOps/s $\color{#d91a1a}-2.71\%$
test_set_nested_new 62.5270μs 26.4031μs 37.8743 KOps/s 38.5029 KOps/s $\color{#d91a1a}-1.63\%$
test_select 96.0190μs 41.7492μs 23.9526 KOps/s 24.1854 KOps/s $\color{#d91a1a}-0.96\%$
test_select_nested 0.1242ms 61.3484μs 16.3003 KOps/s 15.9594 KOps/s $\color{#35bf28}+2.14\%$
test_exclude_nested 0.2247ms 0.1233ms 8.1102 KOps/s 7.9414 KOps/s $\color{#35bf28}+2.13\%$
test_empty[True] 0.7314ms 0.3981ms 2.5122 KOps/s 2.4838 KOps/s $\color{#35bf28}+1.14\%$
test_empty[False] 8.8644μs 1.1200μs 892.8404 KOps/s 874.4922 KOps/s $\color{#35bf28}+2.10\%$
test_unbind_speed 0.3889ms 0.2575ms 3.8834 KOps/s 3.7599 KOps/s $\color{#35bf28}+3.28\%$
test_unbind_speed_stack0 0.3553ms 0.2532ms 3.9500 KOps/s 3.7506 KOps/s $\textbf{\color{#35bf28}+5.32\%}$
test_unbind_speed_stack1 70.2527ms 0.7411ms 1.3493 KOps/s 1.2631 KOps/s $\textbf{\color{#35bf28}+6.82\%}$
test_split 69.6157ms 1.6049ms 623.0781 Ops/s 616.8995 Ops/s $\color{#35bf28}+1.00\%$
test_chunk 68.7275ms 1.5963ms 626.4505 Ops/s 617.5743 Ops/s $\color{#35bf28}+1.44\%$
test_creation[device0] 0.1837ms 0.1027ms 9.7407 KOps/s 9.5717 KOps/s $\color{#35bf28}+1.77\%$
test_creation_from_tensor 3.4377ms 84.0278μs 11.9008 KOps/s 12.1961 KOps/s $\color{#d91a1a}-2.42\%$
test_add_one[memmap_tensor0] 59.8320μs 5.3087μs 188.3688 KOps/s 188.4092 KOps/s $\color{#d91a1a}-0.02\%$
test_contiguous[memmap_tensor0] 20.2580μs 0.6244μs 1.6016 MOps/s 1.5871 MOps/s $\color{#35bf28}+0.91\%$
test_stack[memmap_tensor0] 25.1370μs 3.6057μs 277.3350 KOps/s 271.6281 KOps/s $\color{#35bf28}+2.10\%$
test_memmaptd_index 0.9004ms 0.2284ms 4.3786 KOps/s 4.1063 KOps/s $\textbf{\color{#35bf28}+6.63\%}$
test_memmaptd_index_astensor 0.5613ms 0.3022ms 3.3095 KOps/s 3.1541 KOps/s $\color{#35bf28}+4.93\%$
test_memmaptd_index_op 1.2152ms 0.6024ms 1.6600 KOps/s 1.6873 KOps/s $\color{#d91a1a}-1.62\%$
test_serialize_model 0.1653s 0.1099s 9.0993 Ops/s 9.0490 Ops/s $\color{#35bf28}+0.56\%$
test_serialize_model_pickle 0.4493s 0.3766s 2.6555 Ops/s 2.5883 Ops/s $\color{#35bf28}+2.59\%$
test_serialize_weights 0.1036s 97.7478ms 10.2304 Ops/s 9.2207 Ops/s $\textbf{\color{#35bf28}+10.95\%}$
test_serialize_weights_returnearly 0.1903s 0.1286s 7.7789 Ops/s 7.6010 Ops/s $\color{#35bf28}+2.34\%$
test_serialize_weights_pickle 1.0100s 0.6036s 1.6567 Ops/s 1.5387 Ops/s $\textbf{\color{#35bf28}+7.67\%}$
test_serialize_weights_filesystem 0.1006s 91.6882ms 10.9065 Ops/s 10.7687 Ops/s $\color{#35bf28}+1.28\%$
test_serialize_model_filesystem 98.6332ms 92.1364ms 10.8535 Ops/s 10.9356 Ops/s $\color{#d91a1a}-0.75\%$
test_reshape_pytree 53.6100μs 24.8653μs 40.2167 KOps/s 38.7031 KOps/s $\color{#35bf28}+3.91\%$
test_reshape_td 66.7650μs 32.3776μs 30.8856 KOps/s 30.1740 KOps/s $\color{#35bf28}+2.36\%$
test_view_pytree 71.6440μs 24.5888μs 40.6690 KOps/s 38.9682 KOps/s $\color{#35bf28}+4.36\%$
test_view_td 87.1930μs 36.1032μs 27.6984 KOps/s 27.1864 KOps/s $\color{#35bf28}+1.88\%$
test_unbind_pytree 59.8520μs 28.4938μs 35.0953 KOps/s 33.7620 KOps/s $\color{#35bf28}+3.95\%$
test_unbind_td 0.4261ms 37.9404μs 26.3571 KOps/s 24.9415 KOps/s $\textbf{\color{#35bf28}+5.68\%}$
test_split_pytree 68.2980μs 28.9806μs 34.5058 KOps/s 33.1603 KOps/s $\color{#35bf28}+4.06\%$
test_split_td 0.1203ms 40.6381μs 24.6074 KOps/s 23.8551 KOps/s $\color{#35bf28}+3.15\%$
test_add_pytree 70.9130μs 33.9629μs 29.4439 KOps/s 28.9278 KOps/s $\color{#35bf28}+1.78\%$
test_add_td 0.1229ms 54.2245μs 18.4418 KOps/s 19.2586 KOps/s $\color{#d91a1a}-4.24\%$
test_distributed 0.2091ms 99.8108μs 10.0190 KOps/s 9.7240 KOps/s $\color{#35bf28}+3.03\%$
test_tdmodule 83.6370μs 18.2373μs 54.8326 KOps/s 56.5074 KOps/s $\color{#d91a1a}-2.96\%$
test_tdmodule_dispatch 65.0910μs 35.8539μs 27.8910 KOps/s 28.5589 KOps/s $\color{#d91a1a}-2.34\%$
test_tdseq 47.9100μs 21.2253μs 47.1137 KOps/s 47.9372 KOps/s $\color{#d91a1a}-1.72\%$
test_tdseq_dispatch 59.0900μs 41.4910μs 24.1016 KOps/s 24.4285 KOps/s $\color{#d91a1a}-1.34\%$
test_instantiation_functorch 2.8236ms 1.3068ms 765.2362 Ops/s 769.0844 Ops/s $\color{#d91a1a}-0.50\%$
test_instantiation_td 71.7621ms 1.0872ms 919.8305 Ops/s 981.1128 Ops/s $\textbf{\color{#d91a1a}-6.25\%}$
test_exec_functorch 0.4874ms 0.1593ms 6.2756 KOps/s 6.2175 KOps/s $\color{#35bf28}+0.93\%$
test_exec_functional_call 0.3639ms 0.1488ms 6.7227 KOps/s 6.4386 KOps/s $\color{#35bf28}+4.41\%$
test_exec_td 0.2642ms 0.1431ms 6.9890 KOps/s 6.8872 KOps/s $\color{#35bf28}+1.48\%$
test_exec_td_decorator 0.8003ms 0.2178ms 4.5922 KOps/s 4.4238 KOps/s $\color{#35bf28}+3.81\%$
test_vmap_mlp_speed[True-True] 0.6373ms 0.4779ms 2.0924 KOps/s 2.0599 KOps/s $\color{#35bf28}+1.58\%$
test_vmap_mlp_speed[True-False] 0.7060ms 0.4759ms 2.1011 KOps/s 2.0307 KOps/s $\color{#35bf28}+3.47\%$
test_vmap_mlp_speed[False-True] 0.7231ms 0.3881ms 2.5765 KOps/s 2.4978 KOps/s $\color{#35bf28}+3.15\%$
test_vmap_mlp_speed[False-False] 0.5643ms 0.3886ms 2.5735 KOps/s 2.4973 KOps/s $\color{#35bf28}+3.05\%$
test_vmap_mlp_speed_decorator[True-True] 1.2871ms 0.5480ms 1.8249 KOps/s 1.7719 KOps/s $\color{#35bf28}+2.99\%$
test_vmap_mlp_speed_decorator[True-False] 0.7888ms 0.5512ms 1.8143 KOps/s 1.7687 KOps/s $\color{#35bf28}+2.58\%$
test_vmap_mlp_speed_decorator[False-True] 0.7294ms 0.4479ms 2.2328 KOps/s 2.1508 KOps/s $\color{#35bf28}+3.81\%$
test_vmap_mlp_speed_decorator[False-False] 0.6888ms 0.4466ms 2.2390 KOps/s 2.1999 KOps/s $\color{#35bf28}+1.78\%$
test_to_module_speed[True] 2.4024ms 1.6784ms 595.7984 Ops/s 583.3112 Ops/s $\color{#35bf28}+2.14\%$
test_to_module_speed[False] 2.5468ms 1.6502ms 605.9789 Ops/s 595.2596 Ops/s $\color{#35bf28}+1.80\%$

@vmoens vmoens added the documentation Improvements or additions to documentation label Apr 25, 2024
@vmoens vmoens merged commit 0ba98ad into main Apr 25, 2024
37 of 46 checks passed
@vmoens vmoens deleted the fix-colab branch April 25, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants