Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFIx] FIx tc.update_ #750

Merged
merged 1 commit into from
Apr 25, 2024
Merged

[BugFIx] FIx tc.update_ #750

merged 1 commit into from
Apr 25, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Apr 25, 2024

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 25, 2024
@vmoens vmoens added the bug Something isn't working label Apr 25, 2024
@vmoens vmoens merged commit caea6fb into main Apr 25, 2024
16 of 33 checks passed
@vmoens vmoens deleted the minor-fix branch April 25, 2024 06:57
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 127. Improved: $\large\color{#35bf28}7$. Worsened: $\large\color{#d91a1a}8$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_plain_set_nested 63.7570μs 16.2794μs 61.4274 KOps/s 63.1592 KOps/s $\color{#d91a1a}-2.74\%$
test_plain_set_stack_nested 51.9270μs 16.2607μs 61.4979 KOps/s 63.1180 KOps/s $\color{#d91a1a}-2.57\%$
test_plain_set_nested_inplace 47.8190μs 18.3222μs 54.5786 KOps/s 54.2473 KOps/s $\color{#35bf28}+0.61\%$
test_plain_set_stack_nested_inplace 71.9540μs 18.3368μs 54.5353 KOps/s 54.2048 KOps/s $\color{#35bf28}+0.61\%$
test_items 17.0320μs 2.5673μs 389.5139 KOps/s 369.0202 KOps/s $\textbf{\color{#35bf28}+5.55\%}$
test_items_nested 0.4862ms 0.2686ms 3.7228 KOps/s 3.8337 KOps/s $\color{#d91a1a}-2.89\%$
test_items_nested_locked 0.8314ms 0.2650ms 3.7733 KOps/s 3.8020 KOps/s $\color{#d91a1a}-0.75\%$
test_items_nested_leaf 0.1556ms 77.9609μs 12.8269 KOps/s 13.0343 KOps/s $\color{#d91a1a}-1.59\%$
test_items_stack_nested 0.3984ms 0.2693ms 3.7130 KOps/s 3.7151 KOps/s $\color{#d91a1a}-0.06\%$
test_items_stack_nested_leaf 0.2367ms 80.1858μs 12.4710 KOps/s 12.7407 KOps/s $\color{#d91a1a}-2.12\%$
test_items_stack_nested_locked 0.4899ms 0.2698ms 3.7070 KOps/s 3.7598 KOps/s $\color{#d91a1a}-1.40\%$
test_keys 46.8570μs 3.8331μs 260.8856 KOps/s 261.2971 KOps/s $\color{#d91a1a}-0.16\%$
test_keys_nested 0.2141ms 0.1391ms 7.1897 KOps/s 7.3600 KOps/s $\color{#d91a1a}-2.31\%$
test_keys_nested_locked 2.2120ms 0.1438ms 6.9541 KOps/s 7.0136 KOps/s $\color{#d91a1a}-0.85\%$
test_keys_nested_leaf 0.2304ms 0.1181ms 8.4699 KOps/s 8.6478 KOps/s $\color{#d91a1a}-2.06\%$
test_keys_stack_nested 0.2277ms 0.1372ms 7.2905 KOps/s 7.3903 KOps/s $\color{#d91a1a}-1.35\%$
test_keys_stack_nested_leaf 0.1839ms 0.1170ms 8.5496 KOps/s 8.5815 KOps/s $\color{#d91a1a}-0.37\%$
test_keys_stack_nested_locked 0.2883ms 0.1423ms 7.0297 KOps/s 7.0131 KOps/s $\color{#35bf28}+0.24\%$
test_values 11.4990μs 1.1966μs 835.6741 KOps/s 856.5037 KOps/s $\color{#d91a1a}-2.43\%$
test_values_nested 0.1180ms 50.9260μs 19.6363 KOps/s 19.7306 KOps/s $\color{#d91a1a}-0.48\%$
test_values_nested_locked 0.1005ms 51.1671μs 19.5438 KOps/s 19.6835 KOps/s $\color{#d91a1a}-0.71\%$
test_values_nested_leaf 0.1068ms 46.3467μs 21.5765 KOps/s 21.8072 KOps/s $\color{#d91a1a}-1.06\%$
test_values_stack_nested 0.1176ms 51.7815μs 19.3119 KOps/s 19.3110 KOps/s $+0.00\%$
test_values_stack_nested_leaf 96.5600μs 45.7734μs 21.8468 KOps/s 21.9854 KOps/s $\color{#d91a1a}-0.63\%$
test_values_stack_nested_locked 0.1176ms 51.9069μs 19.2653 KOps/s 19.4520 KOps/s $\color{#d91a1a}-0.96\%$
test_membership 25.4180μs 1.3757μs 726.9017 KOps/s 737.4263 KOps/s $\color{#d91a1a}-1.43\%$
test_membership_nested 49.4140μs 3.4003μs 294.0927 KOps/s 291.4739 KOps/s $\color{#35bf28}+0.90\%$
test_membership_nested_leaf 22.3020μs 3.3993μs 294.1770 KOps/s 290.7331 KOps/s $\color{#35bf28}+1.18\%$
test_membership_stacked_nested 25.8580μs 3.3966μs 294.4127 KOps/s 277.6925 KOps/s $\textbf{\color{#35bf28}+6.02\%}$
test_membership_stacked_nested_leaf 33.2920μs 3.3923μs 294.7845 KOps/s 284.1834 KOps/s $\color{#35bf28}+3.73\%$
test_membership_nested_last 51.1890μs 4.1299μs 242.1339 KOps/s 241.6478 KOps/s $\color{#35bf28}+0.20\%$
test_membership_nested_leaf_last 29.7460μs 4.1979μs 238.2138 KOps/s 240.6073 KOps/s $\color{#d91a1a}-0.99\%$
test_membership_stacked_nested_last 32.4400μs 5.3120μs 188.2524 KOps/s 242.0527 KOps/s $\textbf{\color{#d91a1a}-22.23\%}$
test_membership_stacked_nested_leaf_last 33.4620μs 5.3401μs 187.2632 KOps/s 237.1461 KOps/s $\textbf{\color{#d91a1a}-21.03\%}$
test_nested_getleaf 42.0090μs 10.9193μs 91.5806 KOps/s 89.5425 KOps/s $\color{#35bf28}+2.28\%$
test_nested_get 40.0650μs 9.9824μs 100.1763 KOps/s 97.6549 KOps/s $\color{#35bf28}+2.58\%$
test_stacked_getleaf 58.3290μs 10.4429μs 95.7589 KOps/s 94.2822 KOps/s $\color{#35bf28}+1.57\%$
test_stacked_get 36.1670μs 10.0517μs 99.4855 KOps/s 100.4584 KOps/s $\color{#d91a1a}-0.97\%$
test_nested_getitemleaf 38.4610μs 11.1320μs 89.8311 KOps/s 88.9384 KOps/s $\color{#35bf28}+1.00\%$
test_nested_getitem 34.0640μs 10.2812μs 97.2654 KOps/s 96.1278 KOps/s $\color{#35bf28}+1.18\%$
test_stacked_getitemleaf 34.1040μs 11.0947μs 90.1335 KOps/s 88.5363 KOps/s $\color{#35bf28}+1.80\%$
test_stacked_getitem 34.1040μs 10.2104μs 97.9392 KOps/s 96.6481 KOps/s $\color{#35bf28}+1.34\%$
test_lock_nested 54.4278ms 0.4105ms 2.4361 KOps/s 2.8215 KOps/s $\textbf{\color{#d91a1a}-13.66\%}$
test_lock_stack_nested 0.5223ms 0.3057ms 3.2715 KOps/s 3.2365 KOps/s $\color{#35bf28}+1.08\%$
test_unlock_nested 0.8850ms 0.3590ms 2.7855 KOps/s 2.4141 KOps/s $\textbf{\color{#35bf28}+15.39\%}$
test_unlock_stack_nested 0.5694ms 0.3128ms 3.1967 KOps/s 3.1681 KOps/s $\color{#35bf28}+0.90\%$
test_flatten_speed 0.3132ms 97.0722μs 10.3016 KOps/s 10.4790 KOps/s $\color{#d91a1a}-1.69\%$
test_unflatten_speed 0.6645ms 0.4076ms 2.4534 KOps/s 2.4152 KOps/s $\color{#35bf28}+1.58\%$
test_common_ops 3.6496ms 0.7081ms 1.4122 KOps/s 1.4316 KOps/s $\color{#d91a1a}-1.36\%$
test_creation 0.1130ms 2.0023μs 499.4260 KOps/s 508.4754 KOps/s $\color{#d91a1a}-1.78\%$
test_creation_empty 32.9810μs 9.5478μs 104.7364 KOps/s 112.5335 KOps/s $\textbf{\color{#d91a1a}-6.93\%}$
test_creation_nested_1 38.3820μs 12.6060μs 79.3274 KOps/s 85.5946 KOps/s $\textbf{\color{#d91a1a}-7.32\%}$
test_creation_nested_2 47.1180μs 15.5998μs 64.1033 KOps/s 66.6225 KOps/s $\color{#d91a1a}-3.78\%$
test_clone 0.1519ms 13.6448μs 73.2881 KOps/s 75.1118 KOps/s $\color{#d91a1a}-2.43\%$
test_getitem[int] 37.7400μs 11.7405μs 85.1754 KOps/s 88.2355 KOps/s $\color{#d91a1a}-3.47\%$
test_getitem[slice_int] 60.0920μs 24.3153μs 41.1264 KOps/s 43.4756 KOps/s $\textbf{\color{#d91a1a}-5.40\%}$
test_getitem[range] 82.4740μs 57.7276μs 17.3227 KOps/s 16.6701 KOps/s $\color{#35bf28}+3.92\%$
test_getitem[tuple] 54.3910μs 19.1356μs 52.2585 KOps/s 53.2062 KOps/s $\color{#d91a1a}-1.78\%$
test_getitem[list] 0.1404ms 39.6610μs 25.2137 KOps/s 24.2783 KOps/s $\color{#35bf28}+3.85\%$
test_setitem_dim[int] 93.4250μs 34.8008μs 28.7350 KOps/s 30.0948 KOps/s $\color{#d91a1a}-4.52\%$
test_setitem_dim[slice_int] 0.1442ms 63.6301μs 15.7158 KOps/s 16.2419 KOps/s $\color{#d91a1a}-3.24\%$
test_setitem_dim[range] 0.1391ms 84.0708μs 11.8947 KOps/s 12.1613 KOps/s $\color{#d91a1a}-2.19\%$
test_setitem_dim[tuple] 0.1090ms 50.4473μs 19.8227 KOps/s 20.4178 KOps/s $\color{#d91a1a}-2.91\%$
test_setitem 74.6290μs 20.0211μs 49.9472 KOps/s 51.3197 KOps/s $\color{#d91a1a}-2.67\%$
test_set 61.5450μs 19.4094μs 51.5215 KOps/s 53.0275 KOps/s $\color{#d91a1a}-2.84\%$
test_set_shared 2.1088ms 0.1486ms 6.7294 KOps/s 6.8239 KOps/s $\color{#d91a1a}-1.38\%$
test_update 0.2448ms 20.8090μs 48.0560 KOps/s 49.4262 KOps/s $\color{#d91a1a}-2.77\%$
test_update_nested 0.1434ms 28.3448μs 35.2799 KOps/s 34.4549 KOps/s $\color{#35bf28}+2.39\%$
test_update__nested 92.7130μs 24.7548μs 40.3963 KOps/s 39.3404 KOps/s $\color{#35bf28}+2.68\%$
test_set_nested 93.2940μs 20.9946μs 47.6314 KOps/s 47.8283 KOps/s $\color{#d91a1a}-0.41\%$
test_set_nested_new 0.2331ms 25.3193μs 39.4955 KOps/s 39.6986 KOps/s $\color{#d91a1a}-0.51\%$
test_select 90.0170μs 40.0791μs 24.9507 KOps/s 24.4702 KOps/s $\color{#35bf28}+1.96\%$
test_select_nested 0.1300ms 61.0185μs 16.3885 KOps/s 16.7246 KOps/s $\color{#d91a1a}-2.01\%$
test_exclude_nested 0.1763ms 0.1211ms 8.2606 KOps/s 8.2745 KOps/s $\color{#d91a1a}-0.17\%$
test_empty[True] 0.4997ms 0.3995ms 2.5034 KOps/s 2.5383 KOps/s $\color{#d91a1a}-1.38\%$
test_empty[False] 30.9143μs 1.1305μs 884.5611 KOps/s 909.6836 KOps/s $\color{#d91a1a}-2.76\%$
test_unbind_speed 1.9572ms 0.2635ms 3.7951 KOps/s 3.8444 KOps/s $\color{#d91a1a}-1.28\%$
test_unbind_speed_stack0 0.4842ms 0.2514ms 3.9775 KOps/s 3.9697 KOps/s $\color{#35bf28}+0.20\%$
test_unbind_speed_stack1 77.1850ms 0.7419ms 1.3479 KOps/s 1.2579 KOps/s $\textbf{\color{#35bf28}+7.15\%}$
test_split 80.5097ms 1.6585ms 602.9659 Ops/s 618.9019 Ops/s $\color{#d91a1a}-2.57\%$
test_chunk 79.5450ms 1.6639ms 600.9979 Ops/s 614.3950 Ops/s $\color{#d91a1a}-2.18\%$
test_creation[device0] 0.3084ms 0.1063ms 9.4118 KOps/s 9.5219 KOps/s $\color{#d91a1a}-1.16\%$
test_creation_from_tensor 3.5330ms 83.5968μs 11.9622 KOps/s 11.7986 KOps/s $\color{#35bf28}+1.39\%$
test_add_one[memmap_tensor0] 0.1163ms 5.5386μs 180.5520 KOps/s 193.9542 KOps/s $\textbf{\color{#d91a1a}-6.91\%}$
test_contiguous[memmap_tensor0] 21.4000μs 0.6431μs 1.5551 MOps/s 1.5599 MOps/s $\color{#d91a1a}-0.31\%$
test_stack[memmap_tensor0] 31.5190μs 3.6374μs 274.9239 KOps/s 285.7864 KOps/s $\color{#d91a1a}-3.80\%$
test_memmaptd_index 1.0409ms 0.2380ms 4.2024 KOps/s 4.2265 KOps/s $\color{#d91a1a}-0.57\%$
test_memmaptd_index_astensor 0.9635ms 0.3148ms 3.1770 KOps/s 3.2179 KOps/s $\color{#d91a1a}-1.27\%$
test_memmaptd_index_op 1.1858ms 0.5941ms 1.6831 KOps/s 1.7606 KOps/s $\color{#d91a1a}-4.40\%$
test_serialize_model 0.1838s 0.1120s 8.9314 Ops/s 8.6520 Ops/s $\color{#35bf28}+3.23\%$
test_serialize_model_pickle 0.4542s 0.3751s 2.6661 Ops/s 2.6139 Ops/s $\color{#35bf28}+2.00\%$
test_serialize_weights 0.1104s 0.1028s 9.7318 Ops/s 8.0783 Ops/s $\textbf{\color{#35bf28}+20.47\%}$
test_serialize_weights_returnearly 0.1955s 0.1338s 7.4731 Ops/s 7.7939 Ops/s $\color{#d91a1a}-4.12\%$
test_serialize_weights_pickle 0.8027s 0.5069s 1.9728 Ops/s 1.4979 Ops/s $\textbf{\color{#35bf28}+31.70\%}$
test_serialize_weights_filesystem 0.1002s 95.3832ms 10.4840 Ops/s 10.4650 Ops/s $\color{#35bf28}+0.18\%$
test_serialize_model_filesystem 0.1053s 96.1366ms 10.4019 Ops/s 9.7198 Ops/s $\textbf{\color{#35bf28}+7.02\%}$
test_reshape_pytree 71.0120μs 25.4232μs 39.3342 KOps/s 40.1018 KOps/s $\color{#d91a1a}-1.91\%$
test_reshape_td 78.8370μs 33.2357μs 30.0881 KOps/s 31.0087 KOps/s $\color{#d91a1a}-2.97\%$
test_view_pytree 69.3400μs 25.7058μs 38.9018 KOps/s 40.3009 KOps/s $\color{#d91a1a}-3.47\%$
test_view_td 76.5430μs 37.5384μs 26.6394 KOps/s 27.7329 KOps/s $\color{#d91a1a}-3.94\%$
test_unbind_pytree 65.3620μs 29.0598μs 34.4118 KOps/s 34.8355 KOps/s $\color{#d91a1a}-1.22\%$
test_unbind_td 0.4516ms 37.3513μs 26.7728 KOps/s 26.7180 KOps/s $\color{#35bf28}+0.21\%$
test_split_pytree 69.7500μs 29.5781μs 33.8088 KOps/s 34.3083 KOps/s $\color{#d91a1a}-1.46\%$
test_split_td 0.5912ms 41.6781μs 23.9934 KOps/s 24.8225 KOps/s $\color{#d91a1a}-3.34\%$
test_add_pytree 77.6650μs 34.9979μs 28.5731 KOps/s 29.1723 KOps/s $\color{#d91a1a}-2.05\%$
test_add_td 0.1099ms 54.8919μs 18.2176 KOps/s 19.1385 KOps/s $\color{#d91a1a}-4.81\%$
test_distributed 0.2808ms 0.1030ms 9.7062 KOps/s 9.5776 KOps/s $\color{#35bf28}+1.34\%$
test_tdmodule 89.1070μs 17.5203μs 57.0766 KOps/s 56.3852 KOps/s $\color{#35bf28}+1.23\%$
test_tdmodule_dispatch 66.2130μs 34.5795μs 28.9188 KOps/s 29.3300 KOps/s $\color{#d91a1a}-1.40\%$
test_tdseq 35.5470μs 20.3812μs 49.0648 KOps/s 50.3677 KOps/s $\color{#d91a1a}-2.59\%$
test_tdseq_dispatch 63.9490μs 40.2116μs 24.8684 KOps/s 25.6797 KOps/s $\color{#d91a1a}-3.16\%$
test_instantiation_functorch 1.6149ms 1.3581ms 736.3393 Ops/s 769.8759 Ops/s $\color{#d91a1a}-4.36\%$
test_instantiation_td 1.7080ms 1.0603ms 943.1460 Ops/s 985.7391 Ops/s $\color{#d91a1a}-4.32\%$
test_exec_functorch 0.2597ms 0.1685ms 5.9346 KOps/s 6.1364 KOps/s $\color{#d91a1a}-3.29\%$
test_exec_functional_call 0.2364ms 0.1567ms 6.3809 KOps/s 6.5363 KOps/s $\color{#d91a1a}-2.38\%$
test_exec_td 0.2727ms 0.1519ms 6.5832 KOps/s 6.8926 KOps/s $\color{#d91a1a}-4.49\%$
test_exec_td_decorator 1.0949ms 0.2281ms 4.3849 KOps/s 4.5218 KOps/s $\color{#d91a1a}-3.03\%$
test_vmap_mlp_speed[True-True] 0.7621ms 0.4882ms 2.0485 KOps/s 2.0708 KOps/s $\color{#d91a1a}-1.08\%$
test_vmap_mlp_speed[True-False] 0.7034ms 0.4757ms 2.1024 KOps/s 2.0858 KOps/s $\color{#35bf28}+0.80\%$
test_vmap_mlp_speed[False-True] 0.6639ms 0.3946ms 2.5339 KOps/s 2.5430 KOps/s $\color{#d91a1a}-0.36\%$
test_vmap_mlp_speed[False-False] 0.6618ms 0.3943ms 2.5364 KOps/s 2.5385 KOps/s $\color{#d91a1a}-0.08\%$
test_vmap_mlp_speed_decorator[True-True] 1.2365ms 0.5533ms 1.8073 KOps/s 1.8269 KOps/s $\color{#d91a1a}-1.07\%$
test_vmap_mlp_speed_decorator[True-False] 0.8340ms 0.5535ms 1.8066 KOps/s 1.8319 KOps/s $\color{#d91a1a}-1.38\%$
test_vmap_mlp_speed_decorator[False-True] 0.7303ms 0.4543ms 2.2011 KOps/s 2.2200 KOps/s $\color{#d91a1a}-0.85\%$
test_vmap_mlp_speed_decorator[False-False] 0.6683ms 0.4514ms 2.2151 KOps/s 2.2238 KOps/s $\color{#d91a1a}-0.39\%$
test_to_module_speed[True] 2.6590ms 1.6902ms 591.6553 Ops/s 590.8441 Ops/s $\color{#35bf28}+0.14\%$
test_to_module_speed[False] 83.3593ms 1.8175ms 550.2136 Ops/s 608.7500 Ops/s $\textbf{\color{#d91a1a}-9.62\%}$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants